Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pure C wayland demo #24

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

skoperst
Copy link
Contributor

This implementation uses software rendering in native wayland client.

This implementation uses software rendering in native wayland client.
@dumblob
Copy link
Member

dumblob commented Dec 13, 2019

Didn't test it, but overall the PR looks too good to not merge it 😉. Thanks!

I can see there the following TODO items for future contributors:

  1. change bubble sort at least to quick sort or better to radix sort (which is the fastest to me known method for sorting integers)
  2. in nk_wayland_line_horizontal() there is plenty room for optimization - e.g.:
    1. avoid most of the pointers (especially unsigned int *ptr working with the same memory as unsigned char *pixels)
    2. pass win->data and win->width directly instead of just win
    3. use uint8_t everywhere instead of unsigned int
    4. use restrict for all pointers
    5. manually unroll first two loops (C macros could ease readability)
    6. make it inline
  3. nk_wayland_stroke_line() could also get some optimization love similar to (2) 😉
  4. there are some unimplemented NK_COMMAND_...

@dumblob dumblob merged commit bacdca7 into Immediate-Mode-UI:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants