Fix missed grab state changes in SDL demos #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move grab handling out of `nk_sdl_handle_event` to `nk_sdl_handle_grab`, which is now called outside of the event loop. This change makes the logic similar to the GLFW demos and fixes issues with missed grab state changes and mouse cursor disappearing.
Reverted the order of the SDL_WarpMouseInWindow and SDL_GetMouseState to its original sequence. This avoids cursor warping to the center of screen on older SDL versions It causes an additional SDL_MOUSEMOTION event when ungrabbing, but does not cause any issues.
|
Reverted the order of SDL_SetRelativeMouseMode and SDL_WarpMouseInWindow since it was causing the cursor to warp to center of screen on older SDL versions (tested with SDL 2.0.22) |
|
I like the PR, thanks @paccerdk for spending the time with all the investigations across backends!
Could you please add a comment to the code about this finding? I find it important to have it documented. Thanks! |
|
I tested |
Explains call order of SDL_SetRelativeMouseMode and SDL_SetWindowGrab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved grab handling out of
nk_sdl_handle_eventtonk_sdl_handle_grab, which is now called outside of the event loop.This change makes the logic similar to the GLFW demos and fixes issues with missed grab state changes and mouse cursor disappearing.
Discussed in #608