Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint Parameter Registration #30

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

viceroypenguin
Copy link
Member

  • Change default parameter registration on POST/PATCH/PUT to use [FromBody]
  • Add the ability to override default registration with a custom registration

Fixes #27

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 91.35%. Comparing base (439b187) to head (814e518).

Files Patch % Lines
src/Immediate.Apis.Shared/EndpointRegistration.cs 0.00% 4 Missing ⚠️
...pis.Generators/ImmediateApisGenerator.Transform.cs 83.33% 1 Missing and 1 partial ⚠️
...Immediate.Apis.Generators/ITypeSymbolExtensions.cs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   92.05%   91.35%   -0.71%     
==========================================
  Files          18       19       +1     
  Lines         579      613      +34     
  Branches       61       67       +6     
==========================================
+ Hits          533      560      +27     
- Misses         18       23       +5     
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit da88917 into master Apr 2, 2024
2 of 4 checks passed
@viceroypenguin viceroypenguin deleted the endpoint-registration branch April 2, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapPost/Patch/Put should use [FromBody] by default
1 participant