Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcepawn new syntax #3

Merged
merged 2 commits into from Apr 7, 2015
Merged

Sourcepawn new syntax #3

merged 2 commits into from Apr 7, 2015

Conversation

TheChineese
Copy link
Contributor

Updated to use sourcemod's new syntax (introduced by version 1.7). Especially new type for ConVars (ConVar). So that the ConVar Methodmap can be used (i.e. g_cTest.GetString(buffer, 4)).

Updated to use sourcemod's new syntax (introduced by version 1.7). Especially new type for ConVars (ConVar).
@Impact123
Copy link
Owner

There are a few things missing like using null instead of INVALID_HANDLE and using the methodmap syntax to close handles of files, but other than that it looks good. Thanks!
The reason i haven't done this before is because i wanted to support users who, for whatever reason, still use an old compiler. I've used the view_as operator in CallAdmin to be able to use methodmaps, but now that i think about it, there's no reason to not update the syntax.

Changed return type of AutoExecConfig_SetCreateFile; Changed
INVALID_HANDLE to null. Now using new File type.
@TheChineese
Copy link
Contributor Author

Changed the mentioned points. Did I forgot something?

@ghost
Copy link

ghost commented Apr 7, 2015

btw. you can use #pragma newdecls required for testing.

Impact123 added a commit that referenced this pull request Apr 7, 2015
Updated with sourcemod 1.7 syntax
@Impact123 Impact123 merged commit 287902d into Impact123:master Apr 7, 2015
@Impact123
Copy link
Owner

This looks good, thanks for the effort! I appreciate it.

@TheChineese
Copy link
Contributor Author

@bara20 Did that, but there was no error while using the old syntax for the file handling nor for the decleration of INVALID_HANDLE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants