Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raytrace causing serious FPS lag #903

Closed
MastaNub opened this issue Jan 8, 2019 · 5 comments
Labels
Bug
Milestone

Comments

@MastaNub
Copy link

@MastaNub MastaNub commented Jan 8, 2019

What happens?

Extreme FPS lag

Exact steps to reproduce?

Go into a game with a lot of players/entities. (Hypixel duels lobby)
Turn killaura on.
Enable raytrace in killaura.

  • Impact Version: 4.4 1.12.2 (Latest)
  • Using Optifine? Yes, sir
  • Using LiteLoader? No, sir
  • Enabled mods: Killaura with raytrace on.
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jan 8, 2019

I see the only viable fix is by giving the filter for Kill Aura range a higher priority/order than the filter that performs a raytrace check.

EDIT: A single pass per tick to evaluate all entities that are visible via a raytrace may also be viable

@MastaNub

This comment has been minimized.

Copy link
Author

@MastaNub MastaNub commented Jan 8, 2019

Just reduce raytrace distance; no need for it to raytrace all visible entities. Matching it with set killaura reach should do the trick, or even just setting it to a constant value, like 6 or 10.

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jan 8, 2019

Exactly what I said, effectively

@MastaNub

This comment has been minimized.

Copy link
Author

@MastaNub MastaNub commented Jan 8, 2019

Glad we agree. Now we just need to wait for 4.6 🙏

@zPeanut zPeanut added the Bug label Jul 20, 2019
@zPeanut zPeanut added this to the 4.7 milestone Jul 20, 2019
@ZeroMemes ZeroMemes closed this Jul 22, 2019
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jul 22, 2019

Sorry that this issue kind of got lost, thank you @zPeanut for recovering it. This has been fixed in 4.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.