Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module to know the exact enchantment level of items #957

Closed
SpicyBigGithub opened this issue Feb 25, 2019 · 11 comments
Closed

Module to know the exact enchantment level of items #957

SpicyBigGithub opened this issue Feb 25, 2019 · 11 comments
Labels
Awaiting response The issue doesnt have enough Information to be handled Suggestion The issue is a suggestion of a feature being added to the official Impact build

Comments

@SpicyBigGithub
Copy link

SpicyBigGithub commented Feb 25, 2019

SUGGESTION: I believe this will make many people choose impact over the future, add something that can tell u the exact health of items. like I want to know if my sword, for example, is 32k or 7k. This is only available for 2 clients and one is backdoored and other is 30$, so this would make an impact really stand out

@SuperOP535 SuperOP535 changed the title Suggeztion Module to know the exact enchantment level of items Feb 25, 2019
@SuperOP535 SuperOP535 added the Suggestion The issue is a suggestion of a feature being added to the official Impact build label Feb 25, 2019
@leijurv
Copy link
Member

leijurv commented Feb 25, 2019

exact health of items do you mean durability or enchantment level you keep switching lol

@EmeraldSnorlax
Copy link
Contributor

Just... Press F3 and H.
Then hover over your items....

@ZeroMemes
Copy link
Member

ZeroMemes commented Feb 26, 2019

Enchantment levels should still be apparent even after they surpass level 10

enchantment.level.1=I
enchantment.level.2=II
enchantment.level.3=III
enchantment.level.4=IV
enchantment.level.5=V
enchantment.level.6=VI
enchantment.level.7=VII
enchantment.level.8=VIII
enchantment.level.9=IX
enchantment.level.10=X

Do they not appear as [Enchantment] enchantment.level.32767?

@TheForgottenKing
Copy link

This is a feature in vanilla Minecraft, please elaborate

@LeafHacker LeafHacker added the Awaiting response The issue doesnt have enough Information to be handled label Feb 27, 2019
@aomajn
Copy link

aomajn commented Mar 8, 2019

exact health of items do you mean durability or enchantment level you keep switching lol

I am 100% sure that he means durability. With this thing you can see the real durability of the item that you're holding. Some 2b items have 32k durability but you can also find some items with 7k durability.

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 9, 2019

I've heard of sharpness 32k on 2b before, but not durability.

I know it is possible to /give items with out-of-range durability damage values since this is sometimes used for custom item skins in resource packs, etc (before 1.13 anyway). Don't remember how these items behave though, particularly when wearing down the durability... I seem to recall they don't use durability at all?

@aomajn
Copy link

aomajn commented Mar 9, 2019

On 2b these items are called unbreakables. The thing is that you can actually break them, but their durability is just higher.

@LeafHacker
Copy link
Contributor

I've just had a look at how minecraft handles damage and durability and I don't see how that's possible.

Items have a damage and maxDamage value, durability is calculated on the fly as maxDamage - damage. damage can be changed (either by setting it with the /give command or by using/repairing an item) however maxDamage is hardcoded and can only be changed by modding the game.

If damage is more than maxDamage then the tool will break the next time it is used, so a "32k durability" tool would actually break the next time it is used. A 32k maxDamage simply isn't possible.

Try this by doing /give @s minecraft:wooden_axe 1 32000 in singleplayer and then using the tool in survival...


There is an unbreakable tag, that has nothing to do with damage values (/give @s minecraft:wooden_axe 1 0 {Unbreakable:1})

Setting the Unbreaking enchantment really high would also be close to unbreakable (/give @s minecraft:wooden_axe 1 0 {ench:[{id:34,lvl:32000}]}), this might explain where the confusion is coming from.


Additionally since damage is stored as an int, there's no reason to stop at 32k, you can go all the way to 2,147,483,647. Enchantment levels however are stored as a short which can only go up to 32,767.

@ZeroMemes
Copy link
Member

I presume that the damage level is actually negative and then when calculating the remaining damage you get a higher value from subtracting a negative value!

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 9, 2019

Yes, however the /give command clamps negative damage to 0

@leijurv
Copy link
Member

leijurv commented Mar 22, 2019

Closing in favor of #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting response The issue doesnt have enough Information to be handled Suggestion The issue is a suggestion of a feature being added to the official Impact build
Projects
None yet
Development

No branches or pull requests

8 participants