Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imperia discord v3 #253

Merged
merged 32 commits into from
Jul 8, 2024
Merged

Imperia discord v3 #253

merged 32 commits into from
Jul 8, 2024

Conversation

Danarca
Copy link
Contributor

@Danarca Danarca commented Jun 18, 2024

The big thing here is the break events being replaced by one big super event, some 2700 lines long. Yea.
It will generate 3 options based on the current discord, with overlapping parabolar ranges, which will enable 3 different flavour texts and 3 different options (of course). Luckily the only hard thing to read is the parabolar values.

Other fixes include the implosion mechanic now being way more robust (takes down to 0.33x the dynamic tags as before, which was the error I believe. It "fixes" it (read: pushes the breakpoint away) by having each new country take in the neighbouring states, where possible. The game can only handle 99 dynamic tags, which was usually covered by 2½ big countries imploding. Plus there was some different errors I found in hindsight.
The first month error spamming from the equilibrium variable is also gone, equilibrium is set where discord is set.

EDIT:
I think this branch should be merged before the external removal. I think.

common/history/global/imperia_global.txt Show resolved Hide resolved
@@ -65,7 +69,6 @@
if = {
limit = {
var:political_discord >= 400
always = no # disabled until further notice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo tested on multiplayer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, I'll see if I can figure a test out. After fixing (delaying) the issue I havent seen any weirdness, so thats why Im assuming its fixed.

common/modifiers/imperia_modifiers.txt Outdated Show resolved Hide resolved

discord_break_lvl_1_lower = {
# An inverted parabola formula.. Yes.
# y=-x^2/25+10x-525
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharable desmos link would be nice. (like this: https://www.desmos.com/calculator/mofgjkei6l)

common/script_values/imperia_political_discord_values.txt Outdated Show resolved Hide resolved
max = 100
}

discord_option_1_base_value = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does need some kind of explanation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So its setting a base value for each option in how severe it can get, for the purpose of figuring out how large of a discord loss should be given when selecting that option. I'll add a comment on it.

common/history/global/imperia_global.txt Show resolved Hide resolved
Comment on lines +1744 to +1747
trigger = {
var:first_option != 308
var:second_option != 308
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? why do we need to check this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we dont want the same option appearing twice in the events.
While the second option checks for the presence of the first option (option 3 is not generated yet there), it cannot be shortened down to a comparison between 2 and 3 here, as that would cause option 1 and 3 to collide.
If that was your concern :)

@Danarca Danarca requested a review from HiddeLekanne July 6, 2024 09:10
@Danarca Danarca merged commit 1b6d968 into Imperia-Core Jul 8, 2024
1 check passed
@Danarca Danarca deleted the Imperia-discord-v3 branch July 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants