Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to the data-structures #24

Merged
merged 9 commits into from
Oct 7, 2020
Merged

Corrections to the data-structures #24

merged 9 commits into from
Oct 7, 2020

Conversation

mdavezac
Copy link
Member

@mdavezac mdavezac commented Sep 29, 2020 •
edited

Various small items:

  • Charging points are now charging posts across the code
  • electric_vehicles is now fleet across the code
  • electric vehicles and charging posts have multiple sockets and charger types
  • removes anything related to dask for now. After writing the random allocation algorithm, it's clear it was premature.

Closes #15

Should follow #12 and #17

@mdavezac mdavezac added this to the MVP milestone Sep 29, 2020
@mdavezac mdavezac added this to In progress in RCS via automation Sep 29, 2020
@mdavezac mdavezac mentioned this pull request Oct 5, 2020
Merged
@mdavezac mdavezac marked this pull request as ready for review October 6, 2020 09:32
@mdavezac mdavezac requested review from cc-a, DT16 and toytun October 6, 2020 09:33
@mdavezac
Copy link
Member Author

mdavezac commented Oct 6, 2020

@toytun @DT16 @cc-a, this is now ready for review. It's mostly corrections we have discussed previously and some renaming.

cc-a
cc-a approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Using :py:data for the docstrings is so much nicer.

src/evosim/fleet.py Show resolved Hide resolved
@mdavezac mdavezac mentioned this pull request Oct 7, 2020
Closed
@mdavezac mdavezac merged commit fea141d into develop Oct 7, 2020
RCS automation moved this from In progress to Done Oct 7, 2020
@mdavezac mdavezac deleted the corrections branch October 7, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cc-a cc-a cc-a approved these changes

@DT16 DT16 Awaiting requested review from DT16

@toytun toytun Awaiting requested review from toytun

Assignees
No one assigned
Labels
None yet
Projects
RCS
  
Done
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Charging Posts rather than charging points
2 participants
@mdavezac @cc-a