Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vortex radius square use in linear functions #6

Closed
ngoiz opened this issue Sep 24, 2020 · 2 comments
Closed

Vortex radius square use in linear functions #6

ngoiz opened this issue Sep 24, 2020 · 2 comments

Comments

@ngoiz
Copy link
Collaborator

ngoiz commented Sep 24, 2020

The parameter vortex_radius_sq is calculated from the input for the vortex_radius. However, when the vortex_radius gets small, the square can lead to numerical issues.

In the linear functions it is used solely as a reference of up to where to compute (i.e. the actual value of the square of the vortex_radius is not required) thus vortex_radius_sq could be any number such that it doesn't cause these inaccuracies.

Using: 4a4a1fe

@ArturoMS13
Copy link
Collaborator

i have set "vortex_radius_sq = vortex_radius". We have found accuracy issues when "vortex_radius_sq = vortex_radius*vortex_radius". We believe "vortex_radius_sq" is a limit for numerical accuracy so the changes makes sense.

@ngoiz
Copy link
Collaborator Author

ngoiz commented Sep 24, 2020

Works, thanks!

@ngoiz ngoiz closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants