Sends simulation info to xplane via udp #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script that takes a pickled simulation as input and sends the simulation information to XPlane via UDP
ngoiz
requested changes
Sep 22, 2020
There was a problem hiding this comment.
This is looking really good, many thanks for your contribution!
The main thing we need is a little readme/tutorial/doc on how to use your new script! That way I can try it out and make sure everything is ready for the merge!
I've also added minor comments, mainly on the docstring format such that they get picked up by the documentation generator.
Many thanks and good work!
ngoiz
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script that takes a pickled simulation as input and sends the simulation information to XPlane via UDP