Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fixed bug in Gridbox class #111

Merged
merged 1 commit into from
Oct 14, 2020
Merged

[fix] Fixed bug in Gridbox class #111

merged 1 commit into from
Oct 14, 2020

Conversation

sduess
Copy link
Collaborator

@sduess sduess commented Oct 14, 2020

  • Removed all ".value" in Gridbox class
  • Raised error since coordinates and spacings are not stored in dict format

@sduess
[fix] Fixed bug in Gridbox class
f29b3ce 
- Removed all ".value" in Gridbox class
- Raised error since coordinates and spacings are not stored in dict format
@ArturoMS13 ArturoMS13 self-requested a review October 14, 2020 09:23
ArturoMS13
ArturoMS13 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@ArturoMS13 ArturoMS13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this bug!

@ArturoMS13 ArturoMS13 merged commit 5274bd3 into develop Oct 14, 2020
@ngoiz ngoiz deleted the dev_fix_generator branch May 13, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoMS13 ArturoMS13 ArturoMS13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sduess @ArturoMS13