Update and include features in multibody #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with the previous commits fixes #112
ngoiz
approved these changes
Mar 26, 2021
Comment on lines
+137
to
+139
| # if (self.data.structure.num_bodies > 1): | ||
| # self.data.structure.ini_info.whole_structure_to_local_AFoR(self.data.structure) | ||
| # self.data.structure.timestep_info[0].whole_structure_to_local_AFoR(self.data.structure) |
There was a problem hiding this comment.
Want to kill 👎 or leave 👍 this?
| def initialise(self, data, custom_settings=None): | ||
|
|
||
| self.data = data | ||
| if custom_settings is None: | ||
| self.settings = data.settings[self.solver_id] | ||
| else: | ||
| self.settings = custom_settings | ||
| settings.to_custom_types(self.settings, self.settings_types, self.settings_default) | ||
| settings.to_custom_types(self.settings, self.settings_types, self.settings_default, no_ctype=True) |
There was a problem hiding this comment.
Suggested change
| settings.to_custom_types(self.settings, self.settings_types, self.settings_default, no_ctype=True) | |
| settings.to_custom_types(self.settings, self.settings_types, self.settings_default) |
I guess that thanks to your addition in #123 the no ctype is no longer needed
| @@ -73,9 +92,29 @@ def initialise(self, data, custom_settings=None): | |||
| self.Lambda_dot = np.zeros((self.num_LM_eq,), dtype=ct.c_double, order='F') | |||
| self.Lambda_ddot = np.zeros((self.num_LM_eq,), dtype=ct.c_double, order='F') | |||
|
|
|||
| if self.settings['write_lm']: | |||
| dire = './output/' + self.data.settings['SHARPy']['case'] + '/NonLinearDynamicMultibody/' | |||
There was a problem hiding this comment.
Once we merge #130, the idea would be to change this to dire = self.data.output_folder + '/NonLinearDynamicMultibody/
| @@ -142,8 +142,7 @@ def initialise(self, MBdict_entry, ieq): | |||
| @abstractmethod | |||
| # def staticmat(self, **kwargs): | |||
There was a problem hiding this comment.
Do you want to get rid of the commented function definitions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies some features of the multibody computations which do not influence the user interface:
And it also includes new features:
Requirements before merging: