Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerodynamic forces correction enhancements #140

Merged
merged 62 commits into from
Jun 1, 2021
Merged

Conversation

ngoiz
Copy link
Collaborator

@ngoiz ngoiz commented Apr 15, 2021

This PR tranfsorms the aerodynamic forces correction functions to generators to be used in the coupled solvers. This is for cases where airfoil polars are defined (see updated Case Files documentation).

In this PR we include:

  • Correct forces: transform functions to generators
  • Bug fixes in polar corrections and full documentation
  • Update to the aeroforcescalculator post-processor to output corrected forces and to output aerodynamic forces and moments. The latter are now written on a separate file moments_
  • Changes to the aero data structure such that the aero forces expressed in the beam degrees of freedom are included in the aero time step

@ngoiz
Copy link
Collaborator Author

ngoiz commented May 12, 2021

Thanks both for your comments. I think I have addressed all your points:

  • Horrible aerotstep.aero_forces_beam_dof is gone and instead it goes into structtstep.postproc_nodes['aero_steady_forces] (or unsteady) which is then plotted in Paraview
  • Opted to retain aero_tstep.body_steady_forces since those are a 6x vector and for each surface, which is useful in some cases and it doesn't go in nicely onto the postproc_node strategy as above. These are defined in the AeroTimestepInfo class.
  • Adapted the AeroForcesCalculator postproc to run online and offline
  • Moved the test to the polars tests /tests/uvlm/static/polars

I think this covers my changes. @ArturoMS13 once you are happy with the stability axes and your twisting wings I think this should be then good to go

@ArturoMS13
Copy link
Collaborator

Thank you for the contribution
I have double checked this implementation for wind turbines and it works except from the root regions. I will fix the root soon, but it is not a big deal so this PR can be merged.

@ngoiz ngoiz requested a review from ArturoMS13 June 1, 2021 11:44
Copy link
Collaborator

@ArturoMS13 ArturoMS13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some extra minor changes. Thank you for the contribution

ngoiz and others added 3 commits June 1, 2021 16:29
Co-authored-by: Arturo Muñoz-Simón <39335347+ArturoMS13@users.noreply.github.com>
Co-authored-by: Arturo Muñoz-Simón <39335347+ArturoMS13@users.noreply.github.com>
Co-authored-by: Arturo Muñoz-Simón <39335347+ArturoMS13@users.noreply.github.com>
@ngoiz ngoiz merged commit affec06 into develop Jun 1, 2021
@ngoiz ngoiz deleted the dev_airfoil_polars branch June 1, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants