Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP-Inout change for multiply cs_surface_deflections and loads/strain #162

Merged
merged 2 commits into from
Jun 30, 2021
Merged

UDP-Inout change for multiply cs_surface_deflections and loads/strain #162

merged 2 commits into from
Jun 30, 2021

Conversation

Eriklyy
Copy link
Contributor

@Eriklyy Eriklyy commented Jun 23, 2021

Changed the inout_variables for the UDP connection, in a way that its possible to have multply cs inputs. Also it is possible to send loads and strains now as an output. A simple hale aircraft with two cs_surfaces is used as example.

… possible to have multply cs inputs. Also its possible to send loads and strains now as output. A simple hale aircraft with two cs_surfaces is used as example.
… possible to have multiply cs inputs. Also its possible to send loads and strains now as output. A simple hale aircraft with two cs_surfaces is used as example.
@ngoiz ngoiz self-requested a review June 24, 2021 08:10
@ngoiz ngoiz self-assigned this Jun 24, 2021
Copy link
Collaborator

@ngoiz ngoiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, many thanks @Eriklyy

logger.error(msg)
raise IndexError(msg)

#Had to add this part for for_pos and for_vel since they are arrays.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Had to add this part for for_pos and for_vel since they are arrays.
# Needed for for_pos and for_vel since they are arrays.

Well caught, just editing the comment to make it a bit more impersonal :)

@ngoiz
Copy link
Collaborator

ngoiz commented Jun 28, 2021

I'll test this tomorrow (we have lost our automated testing for the moment) and if it all passes I'll merge into develop.

Thanks again!

@ngoiz
Copy link
Collaborator

ngoiz commented Jun 30, 2021

Everything runs. Many thanks!

@ngoiz ngoiz merged commit 884128e into ImperialCollegeLondon:develop Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants