Fix horseshoe wake handling in UVLM #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bug caused within the steady VLM solver of the UVLM. An outdated initialization function has been re-activated in commit ImperialCollegeLondon/UVLM@7c68eea. The function overwrote the wake shape geometry (zeta star) and made the first wake panel in any case one meter long, resulting in convergence issues in a subsequent DynamicCoupled solver. Since the function is not used at all, I have erased it from the code. The changes have successfully been double-checked with unit test.