Handle absolute tolerance for structural convergence tests as input settings and increase default value #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The absolute tolerance used in xbeam for convergence test is added as a user defined input to the base structural solver and is passed to xbeam with xbopts. This input allows a consistent definition of the absolute tolerance. Further, its default value is increased as it was defined to small to catch very small residuals, which led to non-convergent simulations in the TestGustAssembly unittest.
kccwing
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absolute tolerance used in xbeam for the convergence test is added as a user-defined input to the base structural solver and is passed to xbeam with xbopts. The main reason for the change is a bug in xbeam where the absolute tolerance was defined as too small to be able to catch significant small residuals in convergence tests for which the relative tolerance fails (see ImperialCollegeLondon/xbeam#11). As a result, the structural solver did not converge for the external gust assembler test part of SHARPy's unittest. Further, it has been noticed that the absolute tolerance was defined differently in various functions.
Hence, this pull request includes the following changes: