Updates to plotutils.py and the cantilever_wing demo #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code for toggleable "custom_scaling" and "z_compression" which are used on the updated cantilever wing jupyter notebook file.
Various grammar & typo fixes alongside extra clarifications Added a new "custom_scaling" and "z_compression" parameters: If custom_scaling is set to True, the aspect ratio of the wing will be modelled realistically, and the z axis will be compressed. The integer in z_compression determines how compressed the z axis is when custom_scaling is set to true.
Fixed some typos and improved the grammar in some areas.
Some checks failed on the first pull request, hopefully this should fix it? I downloaded the unedited, original cantilever wing demo and manually changed all the text to what it should be, restarted the kernel in the hopes that it would work. If I messed up some code anywhere on the original one, this should get rid of them?
forgot to remove some tags I was using to troubleshoot the custom scaling, should be fine now
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 156 156
Lines 25923 25923
=======================================
Hits 17422 17422
Misses 8501 8501 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I've tried the same thing that I did on the cantilevered wing demo to try and fix the unsuccessful checks on the wind turbine - hopefully it works.
rafapalacios
approved these changes
Jun 30, 2023
rafapalacios
approved these changes
Jun 30, 2023
|
Merging this - thanks Ozan @boltyboi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Wind turbine demo has also been changed, but I can't change the title.
Plotutils:
Added code for
custom_scalingandz_compression. These are used in the cantilever wing demo to make the simulated wings appear more realistic. They are disabled by default and therefore shouldn't interfere with other demos that use plotutils.Also added a little more detail describing what certain functions actually mean, and cleaned up the formatting a little bit in those areas.
Cantilever wing demo:
Fixed various typos and added extra clarifications on what parts of the code do. Mainly, I've added the
custom_scalingandz_compressionas toggleable features under the simulations, alongside a short explanation of what they do. This should hopefully make the simulations less confusing to newcomers if they decide to enable it. Both of these features are disabled by default and must be manually turned on.Wind turbine demo
Fixed some typos and changed up the grammar in some areas, the results I obtained are inaccurate, however, as when "Steady Simulation" is set to true the results seem to break. I'm not sure how to remove these from the commit though. Sorry about that.