Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor bug fixes #273

Merged
merged 9 commits into from
Dec 27, 2023
Merged

A few minor bug fixes #273

merged 9 commits into from
Dec 27, 2023

Conversation

sduess
Copy link
Collaborator

@sduess sduess commented Dec 18, 2023

Hey,

Here are just a few minor bug fixes:

  1. Fixed the headers and output shapes of the force and moment matrix that are written to a file in the postprocessor aeroforcescalculator.py ( Potential bug in /sharpy/structure/utils/modalutils.py #208).
  2. There was a small bug in modalutils.py that caused not exporting 10 of the last mode shapes if rigid body motions are considered ( Potential bug in /sharpy/structure/utils/modalutils.py #208).
  3. There's a small format bug that does not cause the Jupyter Notebook for the UDP control tutorial to open (at least for my visual code) and it's also not displayed in the documents (might the caused by the same format error).
  4. Most importantly, I deleted some left-over debugging prints giving Ben headaches, although he hopefully uses the remove button himself next time (better than taking paracetamole).
  5. In one previous merge request, the indentation in the savedata.py postprocessor got confused and certain files were not outputted anymore for specific conditions. This is fixed and I updated some "remove if the file exists" commands for all output data cases, otherwise it would not overwrite previous data.

Enjoy your christmas holidays!

- fix intend otherwise these linear/rom systems would only be saved if no data.h5 file exist from the start
- remove all files before it is written as overwriting them causes an Assertation error
In the previous version, less modes are extracted for free flying aircraft because number of rigid body DoFs are wrongly substracted from the total number of modes although the first modes (which are the rigid body modes) are already skipped. Thus if 30 modes are to be exported only 10 mode shapes are created.
- caused error in opening the jupyter notebook and for the  tutorial not to be displayed in the readthedocs documentation
- before it creates an output file with extra columns without any values
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5aa25e3) 67.69% compared to head (f6a01ac) 67.70%.

Files Patch % Lines
sharpy/postproc/savedata.py 52.17% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   67.69%   67.70%           
=======================================
  Files         166      166           
  Lines       26709    26709           
=======================================
+ Hits        18081    18082    +1     
+ Misses       8628     8627    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ben-l-p ben-l-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, changed look good and work for me. Thanks for removing the testing print statements, I can now rest easy :)

@sduess sduess merged commit 029fe56 into main Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants