Default settings get type specified for the setting rather than their own type #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsocarre
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the discussion in #32, default settings now get the value specified in their respective
settings_typesas opposed to having their own type.For an unprovided setting with
settings_type['current_setting'] = list(float)andsettings_default['current_setting'] = [1. , 0., 0.]Old behaviour would process setting as
list. New behaviour will process it asnp.array(as are all user-defined settings that are given the typelist(float)).Fixes #33 as well, no need for the revert.
All tests passed 馃憤