Clean up linear SHARPy's interface with UVLM #60

ngoiz · 2019-12-17T15:37:50Z

This PR fixes #48.

The interface between linear SHARPy and the UVLM has been tidied up with the following improvements:

All functions directly calling a UVLM function have been moved to sharpy/aero/utils/uvlmlib.py. There are no additional imports of the UVLM C++ library elsewhere in the code
Tests and functions have been updated accordingly (and reformatted with spaces for indentation etc)
The functions present in linear.src.libalg have been included in utils.algebra and libalg.py deleted.

ngoiz added 11 commits December 16, 2019 17:39

Formatted libuvlm to spaces

1b73fad

Replaced new import of libuvlm.so in every module for UvlmLib

13153d2

Merged libalg routines into algebra and destroyed libalg

d517400

Corresponding documentation structure update

44a7185

Correctly formatted derivatives tests and removed duplicate

299bc9b

Linear vortex radius consistent with NL and fixed hardcoded test_ders

808b1b9

Vortex radius set only once in linear uvlm. Removed unused lin postprocs

3dc7322

Renamed linear libuvlm and moved cpp calls to uvlmlib

b835c6d

Documentation build

2067a36

Moved remaining functions calling UvlmLib to uvlmlib

024985a

Corresponding documentation build

c63ed47

ngoiz requested a review from fonsocarre December 17, 2019 15:37

fonsocarre approved these changes Dec 17, 2019

View reviewed changes

fonsocarre merged commit f7b4617 into develop Dec 17, 2019

fonsocarre deleted the dev_cleanuplinear branch December 17, 2019 17:06

Provide feedback