Enhanced Frequency Response post-processor and linear system input/output options #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra "/" causing trouble removed.
Includes a source system in src/
Old system was unstable and therefore the correct Hinf norm would be inf but the graphical method produced a finite value
Also returns np.inf for unstable systems
Removing some methods from FrequencyResponse that required a ROM to have been calculated or a ROM in a very specific data structure. The idea is to have ROM comparison tools in a different module and use this postproc solely to calculate the frequency response of a linear system.
ArturoMS13
approved these changes
Apr 27, 2020
Also added the no_ctypes to settings and removed any .value uses
If the timestep info object had a .modal attribute prior to StaticTrim, this would be overwritten by the routine. This change makes a copy of the attribute modal and adds it to the trimmed timestep_info
Codecov Report
@@ Coverage Diff @@
## develop #83 +/- ##
========================================
Coverage 61.58% 61.58%
========================================
Files 119 119
Lines 20524 20524
========================================
Hits 12639 12639
Misses 7885 7885 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes several enhancements in the frequency response postproc:
Option to compute the frequency response for a desired system or systems. This is parsed through a new setting
target_systemwhich takes a list with the chosen systems (for example['aeroelastic', 'aerodynamic', 'structural']would return the frequency response of all those systems.The frequency response data is no longer saved to a
.datfile but rather to a.h5which contains theresponsedata in matrix form with shapeoutput, input, num_frequencies.Option to iteratively compute the H-infinity norm of the systems (
compute_hinf:onin theFrequencyResponsesettings)New settings for in / out behaviour in
LinearAssemblersolver:Option to change the in/out coordinates and channels in the
LinearAssemblersolver. If the system was assembled in modal coordinates it can be projected back to nodal coordinates throughinout_coordinates:nodes.Option to keep only certain in/out channels. Provided through a list with the index of the input/output in
retain_inputsorretain_outputs.modal_tstepsetting. Allows the user to choose the time step that contains the modal information. Useful if you have theModalsolver early on in the SHARPy flow before theLinearAssembler. It defaults to-1which would be the case ifModalruns just beforeLinearAssembler.Other additions:
sharpy/utils/frequencyutils.pycontains several methods to compare frequency responses, including L2-norms, relative errors, etc.