New approach to multibody computations #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need to update stallcheck and beamloads
TODO: We still need to update stallcheck and beamloads
ngoiz
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Thanks for the excellent work @ArturoMS13!
Obviously, I'm no MB expert so I cannot comment much there. I had a genuine question on Nones appearing in aero.timestep_info and a typo I caught.
In any case good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change introduced by this PR is that the structural multibody computations are performed in local A FoR. In DynamicCoupled, the structure variables are kept in the local A FoR of each body (positions, velocities ...) and they are only transformed onto the global A FoR when postprocessing operations are required (plotting, savind data...).
This should not influence results but it improves stability and convergence.
Other minor changes have also been included.