Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linearised all-moving control surfaces #97

Merged
merged 10 commits into from
Sep 29, 2020
Merged

Conversation

ngoiz
Copy link
Collaborator

@ngoiz ngoiz commented Aug 19, 2020

Minor update to support linearised all-moving control surfaces.

In addition, minor bug fix for surfaces located at T-junctions and for control surfaces located in different beams but with the same control input.

Note, the linear control surface assembly is done on a per-node basis, a feature improvement would be to rework this on a per-element basis.

Minor fixes to the LinDynamicSim solver (useful to visualise the linearised control surfaces)

@ngoiz ngoiz requested a review from ArturoMS13 August 19, 2020 08:23
@ngoiz ngoiz changed the title Support for linearised all-moving control surfaces Support linearised all-moving control surfaces Aug 19, 2020
Copy link
Collaborator

@ArturoMS13 ArturoMS13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the commit, moving control surfaces give a great flexibility to the solver. In the future it would be great to generate a library with different moving surfaces. It could be similar to the library of Lagrange constraints.

@ngoiz ngoiz marked this pull request as draft September 12, 2020 08:09
@ngoiz
Copy link
Collaborator Author

ngoiz commented Sep 12, 2020

Found a bug when having the same control surface (i.e. elevator) split in two beams with different xb directions. This is fixed in e02a388, however, prior to merging the following needs to be done:

  • Test implementation in the Horten wing (elevators on the same xb)
  • Implement a simple test script

I'm marking the PR as draft until I finish this

@ngoiz
Copy link
Collaborator Author

ngoiz commented Sep 14, 2020

I have tested the fix for control surfaces that deflect in the same direction for control surfaces on beams with different xbs with positive results.

I included a simple script as a skipped unittest that can be used to visually test changes

@ngoiz ngoiz marked this pull request as ready for review September 14, 2020 17:26
Copy link
Collaborator

@ArturoMS13 ArturoMS13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks for the changes and the code cleaning

@ngoiz ngoiz merged commit 05baf3b into develop Sep 29, 2020
@ngoiz ngoiz deleted the dev_control_surfaces branch September 29, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants