-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support linearised all-moving control surfaces #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the commit, moving control surfaces give a great flexibility to the solver. In the future it would be great to generate a library with different moving surfaces. It could be similar to the library of Lagrange constraints.
Found a bug when having the same control surface (i.e. elevator) split in two beams with different
I'm marking the PR as draft until I finish this |
I have tested the fix for control surfaces that deflect in the same direction for control surfaces on beams with different I included a simple script as a skipped unittest that can be used to visually test changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thanks for the changes and the code cleaning
Minor update to support linearised all-moving control surfaces.
In addition, minor bug fix for surfaces located at T-junctions and for control surfaces located in different beams but with the same control input.
Note, the linear control surface assembly is done on a per-node basis, a feature improvement would be to rework this on a per-element basis.
Minor fixes to the
LinDynamicSim
solver (useful to visualise the linearised control surfaces)