Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker container for WSIMOD #25

Closed
dalonsoa opened this issue Oct 16, 2023 · 0 comments · Fixed by #39
Closed

Create docker container for WSIMOD #25

dalonsoa opened this issue Oct 16, 2023 · 0 comments · Fixed by #39
Assignees
Labels
DAFNI Related to integrating WSIMOD into DAFNI
Milestone

Comments

@dalonsoa
Copy link
Collaborator

After #24 , it should be relatively easy to create a Dockerfile that let you run WSIMOD within a docker container. A docker-compose.yml file should also be added to simplify its local usage and testing. These files could live within a dafni subfolder in the main repository - or directly in the root folder if they are just those two.

The Dockerfile should be written such that it creates an image that, when executed, will run wsimod CLI with the relevant input arguments:

python -m wsimod --settings /data/inputs/settings.toml`

It will trust that, when run, the correct volumes are mounted in the container (namely that /data/inputs and /data/outputs are available) and that the data is available where it is supposed to be, according to the settings.toml file.

While we will do our best to make this file as general as possible, its goal its to confirm to the requirements of the DAFNI framework, so in case of doubt, it will be tailored specifically to fulfill its needs. https://docs.secure.dafni.rl.ac.uk/docs/how-to/how-to-create-a-dafni-ready-model

@dalonsoa dalonsoa added DAFNI Related to integrating WSIMOD into DAFNI Infrastructure Python project, QA and CI/CD related tasks labels Oct 16, 2023
@dalonsoa dalonsoa removed the Infrastructure Python project, QA and CI/CD related tasks label Oct 16, 2023
@dalonsoa dalonsoa added this to the DAFNI Release milestone Oct 17, 2023
@dalonsoa dalonsoa self-assigned this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DAFNI Related to integrating WSIMOD into DAFNI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant