-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize WSIMOD #39
Dockerize WSIMOD #39
Conversation
To test the code: Without DockerJust install WSIMOD and run With DockerThis is meant to run in DAFNI, so the file structure needs to be a little specific.
For reference, this is what I have, with the inputs and outputs in the same folder, the the yaml file called
The output should be conceptually similar to the previous case, getting the same output files in the output folder. @AdrianDAlessandro , @TinyMarsh , @tsmbland , @tg2414 , in case you want to try this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you need to move things around and create files in different locations. Why not just change where those files are in the repo so that it is compatible with DAFNI? Removing as much manual intervention as possible is usually the best way to go here.
Also, in the instructions it's not clear which file WSIMOD_SETTINGS
is meant to be. You use a file called settings_new.yaml
but I don't know where to get that from / make it.
Also, the docker build failed for me, it failed to build wheels for numpy==1.26.2
- this might be because that version of numpy is too recent for the docker image, I'm not sure. It successfully installed in a virtual environment.
Keeping aside the WSIMOD code, there're no files in the repo needed for DAFNI. The files I copy are just taken from the documentation/tutorials, using them as an example of how to run the tool. Neither the Those input files (the settings as well as any required data file) will need to be provided by the user in DAFNI using the DAFNI web interface, so nothing for us to worry about. About the error with On your last comment, you need to include explicitly the environment file to use if you need the environment variables in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, that all makes sense. As long as you can build the docker image, it's fine. I think my issue is probably ARM-related
This PR dockerize the execution of WSIMOD and adds a
docker-compose
file to facilitate local testing and deployment.To be reviewed and merged after #38 , as it builds on top of it.
Closes #25