-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the QA system #32
Conversation
- name: Install and build | ||
run: pip install -r requirements-dev.txt | ||
run: python -m pip install -r requirements-dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious what's the difference between pip install and python -m pip install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at https://stackoverflow.com/questions/25749621/whats-the-difference-between-pip-install-and-python-m-pip-install
We might not need it in this case, but it is becoming more common practice to ensure consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Sensible to ignore the line lengths and docstrings for now. How did using Ruff for automatically fixing some of the problems go?
It implements pre-commit hooks with the main tooling we normally used, except that we are using ruff instead of flake8 and isort. Configuration for this has been included in the
pyproject.toml
file. The workflow file has been updated to run the QA as well as all test in several OS and python versions.A LOT of files appear as modified since running the linters/formatters have modified them, but the functionality remains unchanged. The main files to review are:
As the code was not following any specific style, I had to: