Fix long lines #47
Merged
Fix long lines #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmbland
approved these changes
Jan 10, 2024
| # | ||
| colorama==0.4.6 |
There was a problem hiding this comment.
Curious why colorama is now deleted when none of the dependencies have changed. Is this to do with running pip-compile on windows vs mac? In which case maybe we should have separate requirements files for windows/mac/linux?
There was a problem hiding this comment.
I don't know, to be honest. All tests are passing in all the platforms so if this were something that needs to be different for each of them, I would expect for some of the tests to fail if a platform requires something that has not been installed.
There was a problem hiding this comment.
Looks like it's needed to create coloured terminal text in Windows, but everything seems fine without it on my machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the check of long lines and fixes them.
It is a mixture of manual manipulation and using the rewrap extension for VSCode, so the look and feel might be a bit weird.
Close #34