Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the build of the docs and implements automatic deployment #56

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

dalonsoa
Copy link
Collaborator

This PR simplifies the building of the docs, automatically creating the components library and downloading pandoc if required, and adds an automatic publication step whenever there is a new release.

@dalonsoa dalonsoa linked an issue Jan 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@barneydobson barneydobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I had some trouble with the formatting of component library when I deployed - but this at least seems to look good in the github viewer

@dalonsoa
Copy link
Collaborator Author

Could you elaborate? Now is the time to fix any possible issues on this front.

@barneydobson barneydobson merged commit 8f5b9a4 into main Jan 17, 2024
21 checks passed
@barneydobson
Copy link
Collaborator

Oops sorry I didn't see your message, and merged, and then reverted

@barneydobson
Copy link
Collaborator

It was a while ago - off the top of my head I can't remember, maybe the bullet point formatting seemed unreliable. Were you able to serve the documentation locally to make sure it was formatting properly?

@dalonsoa
Copy link
Collaborator Author

No need to revert! if any change is needed, we will create a new PR.

Yes, I could serve the documentation locally and it seemed OK, as far as I can remember.

@dalonsoa dalonsoa deleted the docs_deploy branch January 17, 2024 12:37
@barneydobson
Copy link
Collaborator

I think if it was OK locally then that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build documentation automatically when there are changes
2 participants