Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellable Game Data RPC message Events #260

Closed
wants to merge 2 commits into from
Closed

Cancellable Game Data RPC message Events #260

wants to merge 2 commits into from

Conversation

kantesilvestrs
Copy link

@kantesilvestrs kantesilvestrs commented Dec 28, 2020

Description

  • Implements cancel evet flag for GameData and GameDataTo client RPC message flags, which can be triggered via CancelEvent action.
  • Implements ICancellableEvent which exposes Action<bool> CancelEvent on events
  • Implements ICancellableEvent on IPlayerChatEvent

Closes issues

@Alexejhero
Copy link
Contributor

@kantesilvestrs
Copy link
Author

@AlexejheroYTB I added #92, but the other ones are not really covered by this PR's scope

@stale
Copy link

stale bot commented Feb 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2021
@js6pak js6pak closed this in #327 Mar 3, 2021
@realfaceitkantesilvestrs

Why does #327 closes this PR @js6pak ?

@js6pak
Copy link
Member

js6pak commented Mar 3, 2021

Because it implemented a way to cancel rpcs and cancellable chat messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Event Prevent Default Add event cancelling to chat messages
4 participants