Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Add lock on game objects #550

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Experimental: Add lock on game objects #550

wants to merge 2 commits into from

Commits on Dec 17, 2023

  1. Add a lock on most interactions with game objects 

    We see rare problems where multiple messages on the same game arriving at
the same game cause issues. This commit adds a coarse-grained lock on
all interactions with a game by adding a binary semaphore.

Because manually adding try{} finally{} blocks seems verbose, I added a
RAII-style LockGuard that locks the semaphore on creation and drops it
when disposed.
    @miniduikboot @js6pak
    miniduikboot authored and js6pak committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d91ab5c View commit details
    Browse the repository at this point in the history

  2. Rework LockGuard to avoid allocations when the lock isn't contested

    @js6pak
    js6pak committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    43acae1 View commit details
    Browse the repository at this point in the history