New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SanctionReason #595
base: master
Are you sure you want to change the base?
Add SanctionReason #595
Conversation
To use this, DisconnectReason should be DisconnectReason.Sanctions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you manually create this file? It should be automatically generated using Dumpostor: https://github.com/Impostor/Dumpostor/blob/master/Dumpostor/DumpostorPlugin.cs#L90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm what is this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i see, i will gen it
Now its dumped with Dumpostor |
Makes maintaining and updating it easier in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't work correctly: the message that is sent when joining a non-existing game changed to something more confusing.
Reproduction steps:
- Start Impostor with a build from your branch.
- Join the non-existent game "AAAA"
- Wait for the error message.
Before: Could not find the game you're looking for.
After: There was a problem finding a game code.\n Not found. Code: 404
I don't believe this change is intended by you, could you look into why this message changed and make sure the old message is shown again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this is currently internal, so what's the point of this PR? Do we want to open this up for plugins?
@@ -1,5 +1,5 @@ | |||
{ | |||
"dumpostorVersion": "1.0.0", | |||
"dumpostorVersion": "1.0.0-dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be regenerated with release dumpostor before merging
Co-authored-by: js6pak <me@6pak.dev>
Probably, im using it on my own server |
bandicam.2024-05-05.22-29-24-670.mp4