Suspicious concatenation

[AppChecker]

Hi.

Please look this section of code:

		$sql =  "   SELECT b.* " .
                "   FROM " . $xoopsDB->prefix("newblocks_bak") . " AS b LEFT JOIN " . $xoopsDB->prefix('block_instance') . " AS i ON b.bid = i.bid " .
                "   WHERE i.instanceid IS NULL";
                "   GROUP BY b.dirname, b.bid";

String " GROUP BY b.dirname, b.bid" is not involved in the concatenation operation.

Probably, it should be:

		$sql =  "   SELECT b.* " .
                "   FROM " . $xoopsDB->prefix("newblocks_bak") . " AS b LEFT JOIN " . $xoopsDB->prefix('block_instance') . " AS i ON b.bid = i.bid " .
                "   WHERE i.instanceid IS NULL".
                "   GROUP BY b.dirname, b.bid";

This possible defect found with AppChecker

[fiammybe]

very very old code, probably never used anymore (migration from old XOOPS sites). Typo that breaks the select visibly.