Rewritten logger to use Monolog #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiammybe
approved these changes
Jan 16, 2020
MekDrop
changed the title
MekDrop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ImpressCMS/ideas#30 and also adds build in Monolog support.
From now there is not possible to turn logging from GUI because database logging also needs somehow to read settings and that is impossible before using database and executing at least one query - so some information can be lost. Logging can be turned on in .env file with
LOGGING_ENABLED=truesetting.Old GUI logger output was removed. Instead from now is possible to choice FirePHP, ChromePHP, BrowserConsole or PHPConsole driver. Using multiple output drivers also is now supported. Driver can be selected with
DEBUG_TOOL=option in .env file.Here is screenshot how result looks with BrowserConsole driver:
