Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes release drafter #594

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Fixes release drafter #594

merged 5 commits into from
Jan 28, 2020

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Jan 27, 2020

Builds but for unknown reason for me ignores if I set push also current branch but at least for 1.4 this should work fine :)

@MekDrop MekDrop added bug infrastructure Infrastructure tasks labels Jan 27, 2020
@MekDrop MekDrop added this to the 2.0.0 Beta 1 milestone Jan 27, 2020
@MekDrop MekDrop requested a review from fiammybe January 27, 2020 11:42
fiammybe
fiammybe approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@fiammybe fiammybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge time saver for releases, but it's also a pain to get it in working order. THanks for this!

@fiammybe fiammybe merged commit 64293d4 into ImpressCMS:master Jan 28, 2020
@MekDrop MekDrop deleted the release-drafter-fix branch January 28, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiammybe fiammybe fiammybe approved these changes

Assignees
No one assigned
Labels
bug infrastructure Infrastructure tasks
Projects
None yet
Milestone
ImpressTNG Beta 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MekDrop @fiammybe