Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the missing templates for the image manager #806

Merged
merged 2 commits into from Nov 17, 2020

Conversation

skenow
Copy link
Contributor

@skenow skenow commented Nov 15, 2020

Fix for #805

@skenow
Copy link
Contributor Author

skenow commented Nov 15, 2020

The only file I really changed was modules/system/icms_version.php - the others would not resolve because of formatting, EOL line differences, or something else I couldn't get past.

@MekDrop MekDrop added this to In progress in ImpressCMS v1.x via automation Nov 17, 2020
@MekDrop MekDrop added the bug label Nov 17, 2020
@MekDrop MekDrop added this to the 1.4.2 milestone Nov 17, 2020
@MekDrop MekDrop linked an issue Nov 17, 2020 that may be closed by this pull request
@MekDrop MekDrop merged commit c11b926 into ImpressCMS:branches/impresscms_1.4 Nov 17, 2020
ImpressCMS v1.x automation moved this from In progress to Done Nov 17, 2020
@MekDrop
Copy link
Member

MekDrop commented Nov 17, 2020

@skenow I think you have enabled some autoformating feature in your editor so that's why here were so many changes. I think this doesn't breaks anything (or if 'yes', at least I didn't see what) and something improves, so I think maybe it's ok.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Missing templates in system module
2 participants