Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Playback speeds exceptions 1.Category:Music 2.Exclude word:Music Include:word:Interview, 3. ...? #387

Closed
deRvyn opened this issue Jul 23, 2020 · 7 comments
Closed

Fixed Playback speeds exceptions 1.Category:Music 2.Exclude word:Music Include:word:Interview, 3. ...? #387

deRvyn opened this issue Jul 23, 2020 · 7 comments
Labels
Feature request Wish or idea 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)

Comments

@deRvyn
Copy link

deRvyn commented Jul 23, 2020 •
edited by ImprovedTube

I like my YouTube videos to default to double speed, but now it's making my YouTube Music songs be double speed, which makes the feature unusable, as I do not want to listen to double speed music...
@ImprovedTube
Copy link
Member

ImprovedTube commented Jul 23, 2020 •
edited

Thank you!
Plan: #551
& we are also looking forward to enable you setting different speeds by:

  • video category

and/or

  • keywords(/phrases/regex) from title tags & descriptions



Old Thread below is just a historic bug

@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes easy labels Jul 23, 2020
@Sawtaytoes
Copy link

How long until this fix appears? Is it in the beta?

@ghost
Copy link

ghost commented Jul 24, 2020

@Sawtaytoes this is not a fix, this is the development of a new feature. Development Not Started Yet

@ImprovedTube ImprovedTube mentioned this issue Jul 27, 2020
Closed
@ImprovedTube ImprovedTube added Feature request Wish or idea and removed Bug Bug or required update after YouTube changes easy labels Jul 27, 2020
@ImprovedTube ImprovedTube changed the title YouTube Music Double Speed Playback speeds exceptions (1.Music.youtube.com 2.Category:Music 3.Exclude word:Music Include:word:Interview, 4. ...?) Jul 27, 2020
@ImprovedTube
Copy link
Member

ImprovedTube commented Jul 28, 2020 •
edited

Hi, we have a lot to do these days. @victor-savinov sorry to mix this thread up

As a quickfix i just made the speed feature skip if the current URL includes "music" edited ImprovedTube's player.js
@bbriano @Sawtaytoes @deRvyn Please consider suggesting easy edits in our files yourself (Github is like Wikipedia!)
We try to make ImprovedTube structured / easy to edit. (Newbie-edits can be efficient & motivating)
(If you would not have thought of the edit above, you could also have searched for "music.youtube" in the ImprovedTube repository. And notice that it only appears in the manifest.json (which is required in every extension) )

Thanks!

@ghost
Copy link

ghost commented Aug 5, 2020

ImprovedTube no longer connects to https://music.youtube.com

@ghost ghost closed this as completed Aug 5, 2020
@Sawtaytoes
Copy link

Sawtaytoes commented Aug 5, 2020 •
edited

Next time, I'll make a PR. Sounds like it wasn't a big deal to fix on my own.

I verified it's already fixed.

@ImprovedTube
Copy link
Member

@Sawtaytoes yay! (Several people here didn't use Github before)

@ImprovedTube ImprovedTube reopened this Nov 4, 2020
@ImprovedTube ImprovedTube changed the title Playback speeds exceptions (1.Music.youtube.com 2.Category:Music 3.Exclude word:Music Include:word:Interview, 4. ...?) Fixed Playback speeds exceptions 1.Category:Music 2.Exclude word:Music Include:word:Interview, 3. ...? [and music.youtube.com] ) Nov 4, 2020
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@ImprovedTube ImprovedTube added the 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) label Feb 14, 2021
@ImprovedTube ImprovedTube changed the title Fixed Playback speeds exceptions 1.Category:Music 2.Exclude word:Music Include:word:Interview, 3. ...? [and music.youtube.com] ) Fixed Playback speeds exceptions 1.Category:Music 2.Exclude word:Music Include:word:Interview, 3. ...? Apr 12, 2021
@ImprovedTube ImprovedTube removed the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 28, 2021
ImprovedTube added a commit that referenced this issue Mar 21, 2023
@ImprovedTube
#1538 #551 #1063 #274 #387 toDo: #680 #213 #1170
2c54b3d
@ImprovedTube ImprovedTube mentioned this issue Sep 30, 2023
Open
20 tasks
ImprovedTube added a commit that referenced this issue Jan 12, 2024
@ImprovedTube
#1538 #551 #1063 #274 #387 toDo: #680 #213 #1170
8d5ed41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Wish or idea 🧩Plan ready Solution or full specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sawtaytoes @ImprovedTube @deRvyn