Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show / Use Youtube Video's #Hash-Tags! (Previously 'breaks "Tags For Youtube" extension') #213

Open
jfolger opened this issue Jan 1, 2020 · 8 comments
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@jfolger
Copy link

jfolger commented Jan 1, 2020

Trying Improve Youtube! for the first time, so far it is really nice and useful. Right out of the gate, though, it broke one of my other useful extensions, "Tags For Youtube", which displays the tags in the description field.

So not really a bug, I guess, but perhaps an adjustment can be made to allow Tags to work, or even add that functionality to Improve?

@ghost ghost added the Feature request Wish or idea label Jan 3, 2020
@ghost ghost added enhancement (hard) and removed Feature request Wish or idea labels Apr 13, 2020
@DankMemeGuy
Copy link

Can this extension just add the tags feature itself? Would solve my problems with it. And it's annoying have an extension just for tags.

@ghost ghost removed Help Wanted labels Dec 11, 2020
@ImprovedTube ImprovedTube added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label Dec 13, 2020
@hboyd2003
Copy link
Contributor

hboyd2003 commented Oct 4, 2022

@jfolger @DankMemeGuy I am not able to find this extension was its name changed?

@hboyd2003 hboyd2003 added Bug Bug or required update after YouTube changes No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?) and removed Feature request Wish or idea labels Oct 4, 2022
@ImprovedTube ImprovedTube added Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) Feature request Wish or idea Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not and removed No entiendo🥺 Seems we didnt understand some part. (Not enough information or unclear wording? Or out of scope?) labels Oct 5, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 5, 2022


  • <meta name="keywords" content="....">

breaks ...-extension

(there usually might not be many people users using another extension even if it has 50 000 users. unless it is/was something we should fix anyways) @hboyd2003


Update August2023:

  • we can always use the following meta data from youtube, avaiable on all video pages, enabling a lot of useful features.
    } else if (name === 'META') {
    if(node.getAttribute('name')) {
    //if(node.getAttribute('name') === 'title') {ImprovedTube.title = node.content;} //duplicate
    //if(node.getAttribute('name') === 'description') {ImprovedTube.description = node.content;} //duplicate
    //if node.getAttribute('name') === 'themeColor') {ImprovedTube.themeColor = node.content;} //might help our darkmode/themes
    //Do we need any of these here before the player starts?
    if(node.getAttribute('name') === 'keywords') {ImprovedTube.keywords = node.content;}
    } else if (node.getAttribute('itemprop')) {
    if(node.getAttribute('itemprop') === 'name') {ImprovedTube.title = node.content;}
    if(node.getAttribute('itemprop') === 'genre') {ImprovedTube.category = node.content;}
    //if(node.getAttribute('itemprop') === 'channelId') {ImprovedTube.channelId = node.content;}
    //if(node.getAttribute('itemprop') === 'videoId') {ImprovedTube.videoId = node.content;}
    //The following infos will enable awesome, smart features. Some of which everyone should use.
    //if(node.getAttribute('itemprop') === 'description') {ImprovedTube.description = node.content;}
    //if(node.getAttribute('itemprop') === 'duration') {ImprovedTube.duration = node.content;}
    //if(node.getAttribute('itemprop') === 'interactionCount'){ImprovedTube.views = node.content;}
    //if(node.getAttribute('itemprop') === 'isFamilyFriendly'){ImprovedTube.isFamilyFriendly = node.content;}
    //if(node.getAttribute('itemprop') === 'unlisted') {ImprovedTube.unlisted = node.content;}
    //if(node.getAttribute('itemprop') === 'regionsAllowed'){ImprovedTube.regionsAllowed = node.content;}
    //if(node.getAttribute('itemprop') === 'paid') {ImprovedTube.paid = node.content;}
    // if(node.getAttribute('itemprop') === 'datePublished' ){ImprovedTube.datePublished = node.content;}
    //to use in the "how long ago"-feature, not to fail without API key? just like the "day-of-week"-feature above
    // if(node.getAttribute('itemprop') === 'uploadDate') {ImprovedTube.uploadDate = node.content;}
    }








the 6 posts below (2022) were off-topic (reminding about YT running multiple GUI versions at the same time - yet we always have the option to sensitively offer GUI on top of Youtube, instead of frickling to integrate our's: CSS position:fixed or sticky)

@hboyd2003
Copy link
Contributor

@ImprovedTube Yes, this is definitely a feature that should be added. It should also be quite easy to implement, however, Youtube has been experimenting with changing the UI so it might be best to wait for it to finalize.
(I have three different UIs on two different accounts so I am not sure which one everyone has and which ones are the test versions. We really need a way to determine which Youtube UI is the current UI)

@ImprovedTube
Copy link
Member

hi @hboyd2003 (are your accounts using different languages?)

@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 7, 2022

wont neccessarily matter for this feature (which could be position:fixed or position:sticky) . Just saying to free / differenciate a feature from (nested) CSS theme.

@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 7, 2022

@hboyd2003
Copy link
Contributor

hboyd2003 commented Oct 8, 2022

@ImprovedTube

(are your accounts using different languages?)

No, all in English. I think they just experiment with random subsets of users.
Here's the different versions I see if you want to look, they are in order of first appearance
Youtube Pre-2022
Youtube Early 2022
Youtube Late 2022

wont necessarily matter for this feature (which could be position:fixed or position:sticky)

True but what they are focusing on currently is the description (and i believe the tags should be hidden until you click the show more button on the description). Though, it might not matter since I am currently focused on bugs so by the time I get through them all the new design might be finalized.

@ImprovedTube ImprovedTube changed the title Breaks "Tags For Youtube" extension Show / Use Youtube Video's #Hash-Tags! (Previously 'breaks "Tags For Youtube" extension') Jan 16, 2023
@ImprovedTube ImprovedTube removed the Bug Bug or required update after YouTube changes label Jan 16, 2023
@ImprovedTube ImprovedTube removed the Rare use-case? Niche or just for fun? (Or if it is currently used, then we predicted/scheduled a successor) label Feb 21, 2023
ImprovedTube added a commit that referenced this issue Mar 21, 2023
@ImprovedTube ImprovedTube added good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Oct 19, 2023
ImprovedTube added a commit that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Solution exists (Here or 3rd party) Exists in any extension, userscript, webapp or app. Written in JS or not up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants