Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame By Frame extension. essential usecase (+ music "1.") #23

Open
wadawada opened this issue Aug 27, 2020 · 8 comments
Open

Frame By Frame extension. essential usecase (+ music "1.") #23

wadawada opened this issue Aug 27, 2020 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@wadawada
Copy link

wadawada commented Aug 27, 2020

↓ Frame By Frame extension: essential usecase (+ music "1.") ↓


Previously: idea: making this number editable:

skip repeat n seconds


Describe the solution you'd like A clear and concise description of what you want to happen.
allow users to set a shortcut to seek backward n seconds

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
the default shortcut is j which seeks backward 10 seconds in player

Relevance / Scope Estimate how many percent of users of Youtube or Improvedtube should be users of your idea?
Users who are into music or changed the speed of player and need to go back to a few seconds often would find it very helpful

Would it be good by default ? (hypothetically)
users have to use shortcuts to use it
using mouse control would be very not accurate and annoying for this purpose

** "Side effects" ** Who might NOT want this? How many percent of users could be bothered by it even filling our menu?
no side effects because you have to set keys in shortcut menu

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
default seeks backward is fixed at 10 seconds, which may not be suitable for all videos

Additional context Add any other context or screenshots about the feature request here.

@ImprovedTube
Copy link
Member

thank you! sorry for the template draft

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 2, 2020

Youtube:

left & right arrow: 5 seconds.
. & , : 1 frame
J & L : 10 seconds.
0-9 for 10% steps.

For smaller steps try our new project frame-by-frame (experimental version)
https://chrome.google.com/webstore/detail/frame-by-frame/cclnaabdfgnehogonpeddbgejclcjneh

For music you might want a timemark or loop of a specific part?
http://www.youtuberepeater.com/watch?v=frxT2qB1POQ&s=9&e=19


So not sure how any people will use this. But you are right it would be good by default.
It wont even need any space in the shortkeys/hotkeys menu if we can just make that number "10" editable.
skip repeat n seconds

@wadawada
Copy link
Author

wadawada commented Sep 4, 2020

Did you just make a new extension for this request? That is amazing!
https://chrome.google.com/webstore/detail/frame-by-frame/cclnaabdfgnehogonpeddbgejclcjneh?hl=en

I am sure some people can use it for professional reasons, considering it allows frame by frame movement
so I have some ideas for this extension

  1. also allow enabling/disabling frame by frame sound (for example, useful for classical pieces)
    and considering it can be used for all players, not only for youtube
  2. port youtube shortcut to other players and allow customizing shortcuts
    left & right arrow: 1 frame
    J & L : 10 seconds.
    0-9 for 10% steps.
    customizing shift+ to n frames/seconds
  3. allow customizing transparency/show/hidden of the border line around the player and information shown in top left box
  4. add semi-transparent speed control slider on top left/right
    (something like this)
    https://chrome.google.com/webstore/detail/speed-control/licimfihnglekdccgjijhmfdocplhdbk?hl=en

Known bug
pause video and move the mouse from inside of player to outside of player will always unpause the video
exception: bug not trigger in youtube main player
but will trigger in youtube miniplayer and all other players

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 15, 2020

@wadawada thanks
Frame-by-frame extension: unpause bug. true
(2) "Youtube's shortkeys everywhere" could be good too²
at least the default , . for frame-by-frame is best (= not overwriting left right )
maybe up/down or scroll too (on mouseover but not mouse over volume slider)
& free keys/combos might be good to be always active by default: shift+left/right ( shift+ ./, shift+up/down)

(²excluding j&k on https://9gag.com etc,...,...?)

(4) buttons. buttons&infos outside of player?(left of player) (so that it wont bother anybody using a screenshot tool? without unpause-bug we can move mouse out. (Outside of players can have highest z-index)

(3) Accidental mouse-over with no expected special keys:
fade out for 4 seconds (50% transparent) (if paused, else 75% in 2 seconds).
after fade out dont overwrite any key.

(1) keeping sound, sounds fun. Not the most trivial tho for music? button: play 1 beat or 1 bar? Repeated tapping change the speed of the music? Music tends to have 60 to 240 bpm similar to human heart beats per minute :D Fast classic music might have < 0.5 tones per frame. https://songbpm.com/@scott-joplin/maple-leaf-rag )__

@wadawada
Copy link
Author

wadawada commented Sep 15, 2020

  1. 1 beat or 1 bar? I am not sure... needs to hear it
    as long as it is stretching time and not changing the pitch
    maybe users can choose how many numbers of "audio frame" to be 1 step?

  2. always active key combo is good

  3. scrollwheel for volume control is a must :)
    I think fade out for 2 seconds is good
    maybe some people want to keep information box
    so having a setting option is good
    Also I personally like black border more than white border

  4. I prefer it inside the player because I already have extentsion to do it outside
    i think it can be adjusted in setttings so either fadeout/outside will resolve a screenshot problem
    also customized shortcut can help

  5. in general, I think the extension needs settings because different users can have different needs for easier control or better screenshot

  6. add a pin button so I can hover the player and "pin it" which allows shortcut to be active even the mouse is not in the player

  7. Youtube player everywhere is nice
    can also take a look at this script
    https://greasyfork.org/en/scripts/381682-html5%E8%A7%86%E9%A2%91%E6%92%AD%E6%94%BE%E5%99%A8%E5%A2%9E%E5%BC%BA%E8%84%9A%E6%9C%AC

a script which alter all html5 videos but lacks a UI so it is not very useful. It has video rotation function which can be useful for some videos

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 4, 2020

Frame by Frame:
2.,3.,4. are essential for the main usecase ( @victor-savinov )
3. only up/down arrow is taken by Youtube. scrolling isnt (besides on mouse over slider. This could be respected by "Frame by Frame")
4. default: outside player ( or include screenshot feature like improvedtube)
5. optional. default settings are important. even for browser extensions / "nerds
6. why, so mouse is not in the view? @wadawada
7.true! we should add buttons and integrate this with improvedtube (all sites permission optional)

@ImprovedTube ImprovedTube changed the title IDEA: shortcut to seek backward n seconds Frame By Frame extension. essential usecase (+ music "1.") Nov 4, 2020
@ImprovedTube ImprovedTube added the help wanted Extra attention is needed label Dec 13, 2020
@wadawada
Copy link
Author

wadawada commented Apr 7, 2021

I tried the new version and it is pretty good and pretty impressive
the new border no longer interfere with the improvedtube progress bar
I also like the idea to press I to hide/show

also
1 I think it is good to change the opacity to maybe 80% or an option to change the opacity of the black background

something I wish I can do with frame by frame in the future is something like in this video
https://www.youtube.com/watch?v=sEQf5lcnj_o
2 I can choose the number of frames to play each time I press < or >
3 and choose to keep sound with it as I go > or <
4 add a speed control slide bar on the video (this is very important because many video player outside youtube don't have this function, the extension below does not work sometimes because it has to be applied to the same web frame as the video)
(something like this https://chrome.google.com/webstore/detail/speed-control/licimfihnglekdccgjijhmfdocplhdbk)

some ideas in the future
5 add maximize video to web screen function
(something like this, this script was powerful but no longer working
https://greasyfork.org/en/scripts/4870-maximize-video)
6 add flip and rotation function
7 add video zoom in/out
8 add all of the above to eventually become youtube everywhere script

@allanlaal
Copy link

use case: mapping these actions to custom mouse buttons & mouse combos

@ImprovedTube ImprovedTube transferred this issue from code-charity/youtube Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants