Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI and s6-overlay-bug #7 #8

Merged
merged 12 commits into from
Dec 20, 2023
Merged

fix: CI and s6-overlay-bug #7 #8

merged 12 commits into from
Dec 20, 2023

Conversation

HussainTechSavvy
Copy link
Member

@HussainTechSavvy HussainTechSavvy commented Dec 20, 2023 •
edited
Loading

Changes proposed

  • Fix: Changed the shebang in certain file in s6-overlay.
  • Upgraded versions of GitHub actions steps.
  • Added image caching support in image-build with docker-buildx.
  • Changed the username reference in docker-login.
  • Changed the branch name according to convension.
  • Changed the image-tag according to convension.
  • Added .editorconfig file.
  • Added new line at end of file.

Check List

  • My code follows the code style of this project.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

  • Will rename the branches according to the names defined in build.yaml after the successful merge of this PR.

@HussainTechSavvy HussainTechSavvy added the enhancement New feature or request label Dec 20, 2023
@HussainTechSavvy HussainTechSavvy self-assigned this Dec 20, 2023
@HussainTechSavvy HussainTechSavvy changed the title Fix ci fix: CI and s6-overlay-bug #7 Dec 20, 2023
@HussainTechSavvy HussainTechSavvy merged commit fbc6b8a into 8.2-s6 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjilka ankitjilka ankitjilka approved these changes

@Luv7804 Luv7804 Luv7804 approved these changes

@Annavar-satish Annavar-satish Annavar-satish approved these changes

@aniketgohelimp aniketgohelimp aniketgohelimp approved these changes

@munir131 munir131 Awaiting requested review from munir131

@lalitmoza lalitmoza Awaiting requested review from lalitmoza

Assignees

@HussainTechSavvy HussainTechSavvy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HussainTechSavvy @ankitjilka @Luv7804 @Annavar-satish @aniketgohelimp