Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded package ID does not match existing App ID #103

Closed
NoName-exe opened this issue Nov 10, 2022 · 15 comments
Closed

Downloaded package ID does not match existing App ID #103

NoName-exe opened this issue Nov 10, 2022 · 15 comments
Labels
bug Something isn't working

Comments

@NoName-exe
Copy link

Used to be that until v5.10,I could update my apps with relatively no issues. However,the new method you're using breaks the app.

I use this repo to get twitter and reddit revanced and it just doesn't work from v6.0 (when the new method was introduced).

Heck,even this doesn't work anymore.

The new method is cool and all but it would be greatly appreciated if you could get those 2 repos to work as they used to until v5.10.

@ImranR98
Copy link
Owner

Could you be more specific? Both repos work fine for me.

@ImranR98 ImranR98 added the needs follow up Further information is requested label Nov 10, 2022
@NoName-exe
Copy link
Author

NoName-exe commented Nov 10, 2022

Could you be more specific? Both repos work fine for me.

Screenshot_20221110-213536_Obtainium.png

Screenshot_20221110-213439_Obtainium.png

Screenshot_20221110-213354_Obtainium.png

This is the error I'm getting and it never used to be there until v6.0

@ImranR98
Copy link
Owner

Ok, that makes sense. The transition from v0.5.10 to v0.6.0 involved a change in the App ID format, so for a while, changing App IDs was allowed so that people could upgrade to v0.6+. But being able to change the App ID upon install is a security risk, so it was disabled in version 0.6.9. I thought there was enough time between v0.6.0 and v0.6.9 that no one was likely to run into this error, guess not.

To fix this, you'll need to remove these Apps and re-add them. This is easy enough if you use multi-select then pick the share URL option, then import the URLs back in.

The other option is to install a version of Obtainium between 0.6.0 and 0.6.8, then update all Apps, then upgrade to the latest version again, but that's more complicated.

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2022
@ImranR98 ImranR98 changed the title New method has some undesirable side effects. Downloaded package ID does not match existing App ID Nov 10, 2022
@ImranR98 ImranR98 pinned this issue Nov 10, 2022
@ImranR98 ImranR98 added wontfix This will not be worked on and removed needs follow up Further information is requested labels Nov 10, 2022
@NoName-exe
Copy link
Author

Ok, that makes sense. The transition from v0.5.10 to v0.6.0 involved a change in the App ID format, so for a while, changing App IDs was allowed so that people could upgrade to v0.6+. But being able to change the App ID upon install is a security risk, so it was disabled in version 0.6.9. I thought there was enough time between v0.6.0 and v0.6.9 that no one was likely to run into this error, guess not.

To fix this, you'll need to remove these Apps and re-add them. This is easy enough if you use multi-select then pick the share URL option, then import the URLs back in.

The other option is to install a version of Obtainium between 0.6.0 and 0.6.8, then update all Apps, then upgrade to the latest version again, but that's more complicated.

Tried both,still doesn't want to work. Guess I'm staying in v0.5.10

@ImranR98 ImranR98 added bug Something isn't working and removed wontfix This will not be worked on labels Nov 10, 2022
@ImranR98 ImranR98 reopened this Nov 10, 2022
@ImranR98
Copy link
Owner

Sorry, I didn't realize this also affected App imports. It should be fixed with the latest version: https://github.com/ImranR98/Obtainium/releases/tag/v0.6.11-beta

@NoName-exe
Copy link
Author

NoName-exe commented Nov 11, 2022

Sorry, I didn't realize this also affected App imports. It should be fixed with the latest version: https://github.com/ImranR98/Obtainium/releases/tag/v0.6.11-beta

Apart from the minor inconvenience of having to import this repo twice, one for twitter and the other for reddit with having to mark Reddit as updated (to follow that repo's naming scheme), everything works flawlessly!!

Thanks for the fix sir.

Also would be cool if you kept the material design 3 type switches like you had in the earlier releases :)

@ImranR98 ImranR98 unpinned this issue Nov 13, 2022
@TheDarkula
Copy link

This is still occurring with Nextcloud Talk on version v0.13.8-beta of Obtanium.

@ImranR98
Copy link
Owner

ImranR98 commented Jun 13, 2023

This is happening because the apps build.gradle is declaring more than one package id (which i didn't know was a thing). In this case obtainium picks the last id which is wrong.

There is no way to tell an advance which id is the right one to use so for such cases you should turn off the "infer app id" toggle at the bottom of the add app page.

That said, the package ID at the top of the file is usually most likely to be the correct one and obtainium currently picks the last id it sees. I'll reopen the issue to remember to correct this later since that will reduce the chances of running into this error.

@ImranR98 ImranR98 reopened this Jun 13, 2023
@TheDarkula
Copy link

Just to keep things entertaining :)

You may want to enable that toggle when a program has already been added to Obtanium under the edit menu, as it is not there.

@einarpersson
Copy link

einarpersson commented Jun 14, 2023

@ImranR98
I'm experiencing this when trying to install synchthing-fork from github.

Turning of "infer app id" indeed seems to have solved the problem. However I have no idea what this means and its potential consequences. I also did not understand what you meant by toggling on after install (I went into edit, but could not find the infer app id setting there). Could you elaborate?

PS. This seems like a very nice project. I have just migrated from iPhone so I'm still unfamiliar to this new ecosystem but I hope that this app will resolve some of my questions and become a trusted companion:)

@ImranR98
Copy link
Owner

@einarpersson an app's ID (the unique identifier the app gives to the OS) must be known before it can be added to Obtainium. "infer app id" just means that obtainium will try to figure out the app's ID before downloading it (by looking at the app's code on GitHub). When this is turned off, the app will be downloaded and its ID will be extracted from the APK directly.

So turning this off has no negative impact - it just means that adding the app will take longer (as it must be downloaded first).

@ghost
Copy link

ghost commented Jun 19, 2023

I've the same story as @einarpersson, but with KeepassDX 3.5.1. Disabling infer app id solves the issue.
Also, thanks a ton for the app. It is a must-have. I would like you to include a donation page, there are surely other people besides me who would like to donate.

@ImranR98
Copy link
Owner

Leaving a note for later: if this error occurs the first time an app is installed and "infer app id" was enabled on add, the error should not be displayed - just quietly update the id instead.

This was referenced Jun 21, 2023
@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label Jun 23, 2023
ImranR98 pushed a commit that referenced this issue Jun 23, 2023
ImranR98 added a commit that referenced this issue Jun 23, 2023
 Automatically fix incorrectly inferred App IDs (#103), Improve version text alignment on app page (#607)
@ImranR98
Copy link
Owner

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Jun 23, 2023
@TheDarkula
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants