-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version extraction via RegEx seems to not work with sub-folders (on SourceForge) #1352
Comments
BTW when mentioning the wiki: |
This issue isn't about version extraction - I just wasn't aware of the fact that SourceForge can have nested subfolders. The current design assumes the root folder will always contain a bunch of subfolders, where each subfolder name is an app version, and the folder's contents are the APKs for that version. That's the system used by OpenCamera, the example app I used when coding this source. The next release will have support for subfolders - then you should then be able to add this app in one of 2 ways:
Also thanks for the correction, I've updated the Wiki. |
Prerequisites
i'm not 100% sure, maybe this is very loosely related to #946.
yes, i'v read https://github.com/ImranR98/Obtainium/wiki but found nothing related to either sub-folders or SourceForge (nor an explanation of what the version extraction via RegEx takes into consideration: just the APKs name, a relative link depending on the "source" aka. distributor or the whole URL?).
Describe the bug
either i don't get completely how the version extraction via RegEx works, or it simply does not work with sub-folders (on SourceForge).
To Reproduce
93
at the time of writing) - the version code is at least used in the file name - Obtainium correctly displays it afterwards as installed.Domination
(which i guess is because the newer of the 2 main folders in the repo is named like that).as the allegedly new version is called
Domination
i thought this would be a good staring point... so my RegEx looks likeDomination\/[\d.]+\/Domination[-_]([\d]+)\.apk
. in desperation i also tried something likehttps:\/\/sourceforge\.net\/projects\/domination\/files\/[Dd]omination\/[\d\p{Punct}]+\/[Dd]omination[\p{Punct}]([\d]+)\.apk.+
and countless variations, but it always tells me "Release version can't be determined" (that's my translation).Please complete the following information:
Additional context
either please tell me what i'm doing wrong at the RegEx version extraction; or making it work even with sub-folders (at least at SourceForge) would be awesome.
The text was updated successfully, but these errors were encountered: