Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override source type option missing for github URLS #1420

Closed
oniGino opened this issue Feb 22, 2024 · 6 comments
Closed

Override source type option missing for github URLS #1420

oniGino opened this issue Feb 22, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@oniGino
Copy link

oniGino commented Feb 22, 2024

Need ability to override source type on a github URL and force HTML or direct download

example:

https://github.com/FurTrader/OverkillSolarBMS/tree/master/OKS_Mobile_App_APK_files

@oniGino oniGino added bug Something isn't working to check Issue has not been reviewed labels Feb 22, 2024
@ImranR98 ImranR98 added enhancement New feature or request TODO Issue to focus on for the next release and removed bug Something isn't working to check Issue has not been reviewed TODO Issue to focus on for the next release labels Feb 25, 2024
@ImranR98
Copy link
Owner

I'm not sure there's a point to this - even if you could use the HTML source for GitHub, it wouldn't work since all the content on the GitHub page is loaded in with JavaScript, which Obtainium cannot scrape.

@ImranR98
Copy link
Owner

Adding this feature is simple, but I'm not sure there's a good use case for it. Closing the issue for now as it would just add confusion (will add it if anyone has a good use case).

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2024
@oniGino
Copy link
Author

oniGino commented Feb 25, 2024

I'm not sure there's a point to this - even if you could use the HTML source for GitHub, it wouldn't work since all the content on the GitHub page is loaded in with JavaScript, which Obtainium cannot scrape.

Fair enough , in that case, I don't have much to say as far as how to solve the problem , in a perfect world they would use versioned releases , but that's unfortunately not up to me..

Can you think if a work around that might work for me here ?

@ImranR98
Copy link
Owner

Actually hold on - the JavaScript thing was an assumption based on past experience with other pages on GitHub. This one does have some content loaded directly, including the APK links.

@ImranR98 ImranR98 reopened this Feb 25, 2024
@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label Feb 25, 2024
@ImranR98
Copy link
Owner

It still doesn't seem possible to do this for your specific case. When I send a request to GitHub with the right headers in Curl, it sends back a page that does contain the APK links. But when I do it in the app (even with the headers), it doesn't. Looks like the headers I put in are being overwritten instead of merged. Not clear how to fix it with the current HTTP library.

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Feb 25, 2024
ImranR98 added a commit that referenced this issue Mar 2, 2024
- Allow any source to be overridden (#1420)
- Bugfix for installing apps with ID change step (#1424)
- Bugfix: 'null' changelog for some track-only apps (#1425)
- Show latest APK name/count on app page (#1426)
- More BG update interval options (#1431)
@ImranR98
Copy link
Owner

ImranR98 commented Mar 2, 2024

@ImranR98 ImranR98 closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants