Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic latest release download to folder #1493

Closed
Lucidic15 opened this issue Mar 22, 2024 · 17 comments
Closed

Generic latest release download to folder #1493

Lucidic15 opened this issue Mar 22, 2024 · 17 comments
Labels
enhancement New feature or request

Comments

@Lucidic15
Copy link

Lucidic15 commented Mar 22, 2024

Add the ability to monitor any github release section to download latest assets, for instance a zip. Not just APKs.

Assign a folder for the downloads. Click "Update" or "Download" to get the latest release.

For example, getting latest Turnip Drivers.

@Lucidic15 Lucidic15 added enhancement New feature or request to check Issue has not been reviewed labels Mar 22, 2024
@ImranR98 ImranR98 removed the to check Issue has not been reviewed label Mar 23, 2024
@DwainZwerg
Copy link
Contributor

DwainZwerg commented Mar 26, 2024

@ImranR98 As a suggestion, I would move the current download folder \storage\emulated\0\Android\data\dev.imranr.obtanium\cache (which is no longer easy to read since Android 13) to \storage\emulated\0\Download (or offer the choice to do so). Then you can not only simply open files that are only to be downloaded but not installed, but also delete files manually if they have not been deleted automatically (due to a bug).

ImranR98 pushed a commit that referenced this issue Apr 7, 2024
@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label Apr 7, 2024
ImranR98 added a commit that referenced this issue Apr 7, 2024
 Add release asset download button (#1493) + Minor UI change
@ImranR98
Copy link
Owner

ImranR98 commented Apr 7, 2024

You can now download any GitHub release asset by clicking 'Download release asset' on the app detail page or from the multi-select menu: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.2

@ImranR98 ImranR98 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Apr 7, 2024
@ImranR98
Copy link
Owner

ImranR98 commented Apr 7, 2024

@DwainZwerg I'd prefer to continue keeping temporary downloads in the cache folder so that Android's "clear cache" function keeps working, and because it's easier than dealing with SAF to use a different path (the Downloads folder probably wouldn't feel right to most users since they never used any 'download' function).

The feature requested here is separate, and files downloaded this way do get sent to the Downloads folder.

@DwainZwerg
Copy link
Contributor

I'd prefer to continue keeping temporary downloads in the cache folder so that Android's "clear cache" function keeps working

I can understand that. Since Android 14, it has become much more complicated to make a good decision.

The feature requested here is separate, and files downloaded this way do get sent to the Downloads folder.

This is fine. Then you can access these downloaded files via the download feature.

@skyerjoe
Copy link

skyerjoe commented Apr 7, 2024

Where ist the Option for the apk Download ?
I couldnt find the Button

Best regards

@ImranR98
Copy link
Owner

ImranR98 commented Apr 7, 2024

Just above the category selector on any app detail page. Or on the apps page, long press on the list to enter multi select mode, select some app, then click the three dot menu -> "Download release asset".

The first time after updating, use pull to refresh so that all github apps are rechecked.

@Lucidic15
Copy link
Author

Hmm, sounds like from your last message here that you changed it so that you can download all assets from a github that HAS an APK in the release.

With the original enhancement, I was hoping to add stuff to watch and collect that doesn't have an APK. Like Turnip drivers. Doesn't seem like this is an option still, can you confirm?

@ImranR98
Copy link
Owner

ImranR98 commented Apr 8, 2024

No, this works for track-only apps too.

@Lucidic15
Copy link
Author

That's great, but I am not understanding how to add something like Turnip Drivers.

I went to Add Apps, enter the releases URL in App Source URL, then add. I get, cannot find suitable release.

What am I missing? Do I need to do regex to accept only certain assets in the release that aren't APKs?

@ImranR98
Copy link
Owner

ImranR98 commented Apr 8, 2024

You need to enable track-only mode in the additional settings

@Lucidic15
Copy link
Author

Ok, so it will show me that there is an update next time there is a release that isnt the release after I have added it to my tracking list? But I will still need to go to the github to grab it. No option to have obtanium pull anything?

@ImranR98
Copy link
Owner

ImranR98 commented Apr 8, 2024

Yes, you'll be notified of new releases. You can also download any release assets (including source code zip/tar) from inside the app.

@Lucidic15
Copy link
Author

Ahh, download release asset, I see it now.

Thank you for adding this feature!

@Lucidic15
Copy link
Author

Though, picking a download folder would be nice. But maybe nitpicking my use case. Up to you on that one of course. Maybe a setting, Download Track Only to Downloads / Pick Download Location for Track Only

@Lucidic15
Copy link
Author

Lucidic15 commented Apr 8, 2024

It was brought up (in AYN Odin 2 Discord) that it would be SUPER cool to actually pick your download directory once PER tracking. So you then after can go in and click download and have it go where you want. Of course an option on the page to change it after its set or cannot be found anymore.

@ImranR98
Copy link
Owner

ImranR98 commented Apr 8, 2024

You can open another issue for that

@DwainZwerg
Copy link
Contributor

Aren't #29, #1181 and #1007 solved by this commit so that they can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants