Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default 3rd party app icon not visible in dark mode #1637

Closed
grrrrr opened this issue May 21, 2024 · 4 comments
Closed

default 3rd party app icon not visible in dark mode #1637

grrrrr opened this issue May 21, 2024 · 4 comments
Labels
bug Something isn't working UI This bug/feature is skin deep

Comments

@grrrrr
Copy link

grrrrr commented May 21, 2024

Describe the bug

When in dark mode, if an app added to obtanium does not yet have an app icon, the default icon is very hard to view (purple on black).

If the theme for obtanium is light the default icon is more visible.

Screenshots and Logs

icon2

Please complete the following information:

  • Device: Pixel 7a
  • OS: GrapheneOS
  • Obtainium Version: 1.1.9
@grrrrr grrrrr added bug Something isn't working to check Issue has not been reviewed labels May 21, 2024
@ImranR98 ImranR98 added UI This bug/feature is skin deep and removed to check Issue has not been reviewed labels May 21, 2024
ImranR98 pushed a commit that referenced this issue May 22, 2024
Attempt to improve app load time
9c46e3f 
Slight icon opacity tweak (#1637)
@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label May 24, 2024
@ImranR98 ImranR98 mentioned this issue May 24, 2024
Merged
ImranR98 added a commit that referenced this issue May 24, 2024
@ImranR98
Merge pull request #1643 from ImranR98/dev
7071e34 
- Bugfix: Include GitLab token in APK request (#1622)
- Bugfix: Don't trim trailing slashes when parsing links (#1625)
- Improve contrast of placeholder icon in dark mode (#1637) 
- Improve app loading times
- Revert a previous change to background downloads
- Add a "clear logs" button
@ImranR98
Copy link
Owner

Improved the contrast to make it more consistent: https://github.com/ImranR98/Obtainium/releases/tag/v1.1.10

@grrrrr
Copy link
Author

grrrrr commented May 24, 2024

Thanks @ImranR98 did the icon get included in that push or was it a code change only? It still looks similar to what it was

@ImranR98
Copy link
Owner

The change might not be noticeable without a side by side comparison - I only increased the opacity by around 10%. It's a subjective thing but I don't want the placeholder icon to stand out too much.

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label May 24, 2024
@grrrrr
Copy link
Author

grrrrr commented May 24, 2024

ok, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working UI This bug/feature is skin deep
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grrrrr @ImranR98