Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJ PDF repo not working #3

Closed
berserkwarwolf opened this issue Aug 31, 2022 · 6 comments
Closed

MJ PDF repo not working #3

berserkwarwolf opened this issue Aug 31, 2022 · 6 comments
Labels
blocked This is dependent on external changes bug Something isn't working

Comments

@berserkwarwolf
Copy link

https://gitlab.com/mudlej_android/mj_pdf_reader

It has a direct link to the APK in the releases section, packages. What is happening?

@ImranR98
Copy link
Owner

ImranR98 commented Sep 1, 2022

The GitLab releases page cannot be scraped using the existing solution used in Obtainium, because the release info is dynamically loaded in with JavaScript. So the only way to currently get this info is through the tags RSS feed. Unfortunately it looks like this feed doesn't always contain a link to the release APK like I thought it did - it depends on how the app developer does things. Here's the Aurora Store RSS feed for comparison.

For now, nothing can be done until someone finds a way to scrape the releases page itself. I'll add a more informative error message about this later.

@ImranR98 ImranR98 added the bug Something isn't working label Sep 3, 2022
@ImranR98 ImranR98 added the blocked This is dependent on external changes label Nov 6, 2022
@ImranR98
Copy link
Owner

Closing as there does not seem to be any way to enable this.

@m-rey
Copy link

m-rey commented Jul 15, 2023

while trying out other open source apps like Obtainium, I've noticed that Android OSS Release Tracker supports adding GitLab repos.

Maybe it's worth checking out how it's done there?

edit: while that app seems to detect the latest release version, it then merely links to it'
s release webpage. It doesn't scrape that page to retrieve the link to the actual apk file. my bad.

@ImranR98
Copy link
Owner

Not sure whether they actually scrape the APK file, but looking through their code reminded me that Obtainium now has an option to add a GitLab Access Token to enable search. The same token could be used to get release data via the API instead of the RSS feed (which is what it uses now).

The next update will use the GitLab API for better APK discovery, with the RSS feed as a fallback.

Thanks for bringing up this old issue.

@ImranR98 ImranR98 reopened this Jul 15, 2023
ImranR98 added a commit that referenced this issue Jul 15, 2023
 Add better GitLab APK discover when API key set (#3 and duplicates #41, #282, partly #356)
@ImranR98
Copy link
Owner

Users with GitLab API keys can now add this repo: https://github.com/ImranR98/Obtainium/releases/tag/v0.13.16-beta

@foolishgrunt
Copy link

foolishgrunt commented Dec 16, 2023

Apologies for resurrecting this - feel free to tell me if I should start a new discussion. But apparently the developer of MJ PDF no longer hosts apk's directly on GitLab: he links to a download page on archive.org, where the only direct download is a .zip file. So my question is twofold:

  1. Can Obtainium unpackage .zip files?
  2. If yes, is there any way to point it to navigate through the intermediate archive.org page to the download? (I'm aware that I could add the archive.org page directly as an HTML source, but it looks like that URL changes with every new release.)

My intermediate workaround is to download from the Izzyondroid repo, but that's not an ideal solution.

EDIT: just stumbled across #983, so it looks like the answer to my first question is 'no.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This is dependent on external changes bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants