Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete flags #859

Open
mccarverone opened this issue Sep 20, 2022 · 2 comments
Open

Obsolete flags #859

mccarverone opened this issue Sep 20, 2022 · 2 comments

Comments

@mccarverone
Copy link

By running the nice utility eix-test-obsolete it turns out that the following flags entries are operating on non existent packages. Many might have just been renamed, or they are no longer in main gentoo repository. Shall we remove them altogether? Would you care for a few commits?

Non-matching or empty entries in /etc/portage/package.cflags:
www-client/torbrowser *FLAGS-="${IPAPTA}"
=sys-apps/gawk-4.1.4 *FLAGS-="${IPAPTA}"
dev-qt/qtwebkit *FLAGS-="${IPAPTA}"
app-emulation/libpod *FLAGS-=-flto*
<app-text/mupdf-1.12.0 *FLAGS-=-flto*
cross-arm-none-eabi/newlib *FLAGS-=-flto*
cross-i686-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
cross-x86_64-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
games-fps/zandronum *FLAGS-=-flto*
dev-libs/intel-neo *FLAGS-=-flto*
dev-qt/qtwebkit *FLAGS-=-flto*
dev-tex/chktex "use pcre && FlagSubAllFlags -flto*"
games-emulation/mupen64plus-libretro *FLAGS-=-flto*
games-emulation/parallel-n64-libretro *FLAGS-=-flto*
net-libs/webkit-gtk:3 *FLAGS-=-flto*
sci-libs/arrayfire *FLAGS-=-flto*
sci-libs/scipy *FLAGS-=-flto*
sys-apps/nix *FLAGS-=-flto*
sys-fabric/libibverbs *FLAGS-=-flto*
dev-util/cargo *FLAGS+=-ffat-lto-objects
dev-python/notify-python NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/libgnome-keyring NOCOMMON_OVERRIDE_LIBTOOL=yes
gui-apps/gammastep *FLAGS+='-fno-finite-math-only'
<media-libs/opus-1.3.1-r1 /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
media-sound/mumble /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
www-client/torbrowser *FLAGS-="-mtls-dialect=gnu2"
@SigHunter
Copy link

SigHunter commented May 20, 2023

the current list of obsolete packages in package.cflags are

Non-matching or empty entries in /etc/portage/package.cflags:
www-client/torbrowser *FLAGS-="${IPAPTA}"
=sys-apps/gawk-4.1.4 *FLAGS-="${IPAPTA}"
dev-qt/qtwebkit *FLAGS-="${IPAPTA}"
app-emulation/libpod *FLAGS-=-flto*
<app-text/mupdf-1.12.0 *FLAGS-=-flto*
cross-arm-none-eabi/newlib *FLAGS-=-flto*
cross-i686-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
cross-x86_64-w64-mingw32/mingw64-runtime *FLAGS-=-flto*
games-fps/zandronum *FLAGS-=-flto*
dev-libs/intel-neo *FLAGS-=-flto*
dev-qt/qtwebkit *FLAGS-=-flto*
dev-tex/chktex "use pcre && FlagSubAllFlags -flto*"
games-emulation/mupen64plus-libretro *FLAGS-=-flto*
games-emulation/parallel-n64-libretro *FLAGS-=-flto*
net-libs/webkit-gtk:3 *FLAGS-=-flto*
sci-libs/arrayfire *FLAGS-=-flto*
sci-libs/scipy *FLAGS-=-flto*
sys-apps/nix *FLAGS-=-flto*
sys-fabric/libibverbs *FLAGS-=-flto*
www-misc/shellinabox *FLAGS-=-flto*
dev-util/cargo *FLAGS+=-ffat-lto-objects
=sys-libs/efivar-37 *FLAGS+="-flto-partition=none"
media-libs/ilmbase *FLAGS+=-lrt
dev-python/notify-python NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/gconf NOCOMMON_OVERRIDE_LIBTOOL=yes
gnome-base/libgnome-keyring NOCOMMON_OVERRIDE_LIBTOOL=yes
gui-apps/gammastep *FLAGS+='-fno-finite-math-only'
<media-libs/opus-1.3.1-r1 /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
media-sound/mumble /-Ofast/'-O3 ${SAFER_FAST_MATH}' /-ffast-math/'${SAFER_FAST_MATH}'
www-client/torbrowser *FLAGS-="-mtls-dialect=gnu2"

those entries currently do not do anything because the corresponding packages do not exist in ::gentoo repository and could therefore, in my understanding, be removed without impact. or some of them could be matched to the current package in case of renaming (like media-sound/mumble is net-voip/mumble)

do they need to be keept for backwards compatibility?
this messes up eix-test-obsolete :)

@wolfwood
Copy link
Contributor

wolfwood commented May 20, 2023

renames and deprecated packages are one thing, but packages from common overlays (which you personally do not have) shouldn't be excluded.

in addition, the way cross-dev works is by creating a local overlay with a cross-* prefix and those patches are very necessary to keep those toolchains working.

jhatler added a commit to jhatler/gentooLTO that referenced this issue Dec 26, 2023
This removes workarounds for packages which are not present in the
portage tree. It also updates the names of some packages which have
been renamed.

This is based on the upstream issue referenced below.

Refs: InBetweenNames#859
Signed-off-by: Jaremy Hatler <hatler.jaremy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants