Scribe log messages should have millisecond level timestamp #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,10 @@ const std::string scribeversion("2.2"); | |||
| time(&now); \ | |||
| ctime_r(&now, dbgtime); \ | |||
| dbgtime[24] = '\0'; \ | |||
| fprintf(stderr,"[%s] " #format_string " \n", dbgtime,##__VA_ARGS__); \ | |||
| struct timeval tv; \ | |||
| gettimeofday(&tv, NULL); \ | |||
There was a problem hiding this comment.
This introduces one extra call. Try the following:
- first call gettimeofday()
- take tv.sec and pass it to ctime_r()
- together print sec and millisec parts
|
The time format printed now is quite confusing (the millisecond is appearing separately after year). Can we explore some other format that allows seconds and milliseconds to appear together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample log : [Wed Aug 13 15:59:14 2014 486] "throttle denying request for queue size <31681> with a batch of" " <1> messages for [benchmark_collector] category. It would exceed max queue size <30000>"