Skip to content

Commit

Permalink
Fix 2024.2 compatibility problem
Browse files Browse the repository at this point in the history
  • Loading branch information
InSyncWithFoo committed Jun 14, 2024
1 parent eb30669 commit ea8a79c
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 24 deletions.
48 changes: 26 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Pyright for PyCharm

[![Build](https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml/badge.svg)](https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml)
[![Docs](https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/docs.yaml/badge.svg)](https://insyncwithfoo.github.io/pyright-for-pycharm)
[![Version](https://img.shields.io/jetbrains/plugin/v/24145)][4]
[![Rating](https://img.shields.io/jetbrains/plugin/r/rating/24145)][4]
[![Downloads](https://img.shields.io/jetbrains/plugin/d/24145)][4]
[![Build](https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml/badge.svg)][4]
[![Docs](https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/docs.yaml/badge.svg)][5]
[![Version](https://img.shields.io/jetbrains/plugin/v/24145)][6]
[![Rating](https://img.shields.io/jetbrains/plugin/r/rating/24145)][7]
[![Downloads](https://img.shields.io/jetbrains/plugin/d/24145)][8]

![](docs/assets/cli-demo-2.png)

Expand Down Expand Up @@ -42,34 +42,38 @@ You should see the annotations in a few seconds.

## Installation

This plugin [is available][4] on the Marketplace.
You can also download the ZIP files manually from [the <i>Releases</i> tab][5],
[the `build` branch][6] or [the <i>Actions</i> tab][7]
and follow the instructions described [here][8].
This plugin [is available][8] on the Marketplace.
You can also download the ZIP files manually from [the <i>Releases</i> tab][9],
[the `build` branch][10] or [the <i>Actions</i> tab][11]
and follow the instructions described [here][12].

Currently supported versions:
2024.1 (build 241.14494.241) - 2024.2.* (build 242.*).


## Credits

Most of the code is derived from [@koxudaxi/ruff-pycharm-plugin][9].
Most of the code is derived from [@koxudaxi/ruff-pycharm-plugin][13].
It is such a fortune that that plugin does almost the same thing
and is also written in Kotlin, and hence easily understandable.

The SVG and PNG logos are derived from [the README image][10]
The SVG and PNG logos are derived from [the README image][14]
of the [@microsoft/pyright][1] repository,
generated using Inkscape's autotrace feature.

Some other files are based on or copied directly from
[@JetBrains/intellij-platform-plugin-template][11].


[4]: https://plugins.jetbrains.com/plugin/24145
[5]: https://github.com/InSyncWithFoo/pyright-for-pycharm/releases
[6]: https://github.com/InSyncWithFoo/pyright-for-pycharm/tree/build
[7]: https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml
[8]: https://www.jetbrains.com/help/pycharm/managing-plugins.html#install_plugin_from_disk
[9]: https://github.com/koxudaxi/ruff-pycharm-plugin
[10]: https://github.com/microsoft/pyright/blob/main/docs/img/PyrightLarge.png
[11]: https://github.com/JetBrains/intellij-platform-plugin-template
[@JetBrains/intellij-platform-plugin-template][15].


[4]: https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml
[5]: https://insyncwithfoo.github.io/pyright-for-pycharm
[6]: https://plugins.jetbrains.com/plugin/24145/versions
[7]: https://plugins.jetbrains.com/plugin/24145/reviews
[8]: https://plugins.jetbrains.com/plugin/24145
[9]: https://github.com/InSyncWithFoo/pyright-for-pycharm/releases
[10]: https://github.com/InSyncWithFoo/pyright-for-pycharm/tree/build
[11]: https://github.com/InSyncWithFoo/pyright-for-pycharm/actions/workflows/build.yaml
[12]: https://www.jetbrains.com/help/pycharm/managing-plugins.html#install_plugin_from_disk
[13]: https://github.com/koxudaxi/ruff-pycharm-plugin
[14]: https://github.com/microsoft/pyright/blob/main/docs/img/PyrightLarge.png
[15]: https://github.com/JetBrains/intellij-platform-plugin-template
1 change: 1 addition & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ tasks {
systemProperty("ide.experimental.ui", "true")
systemProperty("projectView.hide.dot.idea", "false")
systemProperty("terminal.new.ui", "false")
systemProperty("ide.tree.painter.compact.default", "true")
}

wrapper {
Expand Down
2 changes: 1 addition & 1 deletion gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
# Darwin, MinGW, and NonStop.
#
# (3) This script is generated from the Groovy template
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# within the Gradle project.
#
# You can find Gradle at https://github.com/gradle/gradle/.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal abstract class PyrightCommand {

private val commandLine: GeneralCommandLine
get() = GeneralCommandLine(fragments).apply {
withWorkDirectory(workingDirectory)
withWorkDirectory(this@PyrightCommand.workingDirectory)
withCharset(Charsets.UTF_8)
}

Expand Down

0 comments on commit ea8a79c

Please sign in to comment.