Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to org.jetbrains.intellij.platform v2.0.0 #45

Merged
merged 18 commits into from
Jul 13, 2024
Merged

Switch to org.jetbrains.intellij.platform v2.0.0 #45

merged 18 commits into from
Jul 13, 2024

Conversation

InSyncWithFoo
Copy link
Owner

@InSyncWithFoo InSyncWithFoo commented Jun 10, 2024 •
edited
Loading

Fixes #44.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Class member can have 'private' visibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.5
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@InSyncWithFoo InSyncWithFoo changed the title Switch to org.jetbrains.intellij.platform v2.0.0-beta6 Switch to org.jetbrains.intellij.platform v2.0.0 Jun 14, 2024
@InSyncWithFoo InSyncWithFoo force-pushed the issue-44 branch 2 times, most recently from 92e7a55 to 6aecef3 Compare June 14, 2024 21:19
@InSyncWithFoo
Copy link
Owner Author

This should be mergeable once IPGP #1658 is fixed.

@InSyncWithFoo InSyncWithFoo mentioned this pull request Jun 21, 2024
Merged
@InSyncWithFoo
Copy link
Owner Author

InSyncWithFoo commented Jul 3, 2024 •
edited
Loading

Now verifyPlugin works, but tests are failing for no apparent reasons.

@InSyncWithFoo InSyncWithFoo marked this pull request as ready for review July 13, 2024 19:00
@InSyncWithFoo InSyncWithFoo merged commit ace16ca into master Jul 13, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 13, 2024
@InSyncWithFoo
Switch to org.jetbrains.intellij.platform v2.0.0 (#44, #45) (ace16ca)
b521f27
@InSyncWithFoo InSyncWithFoo deleted the issue-44 branch July 14, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to use IntelliJ Platform Gradle Plugin 2.x when building against 2024.2 (EAP)
1 participant
@InSyncWithFoo