Add support for LSP4IJ

[InSyncWithFoo]

Fixes #38.

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.5
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[InSyncWithFoo]

A few problems to be resolved:

• The plugin needs to be able to:
  • Signal "do not start server" without throwing errors
  • Start and stop existing server(s) at will when the running mode is changed.
• Configurations must be sent via workspace/didChangeConfiguration (see sister #1)

[InSyncWithFoo]

The verifier seems to be failing for whatever reason. That, too, needs to be taken care of.

[angelozerr]

Signal "do not start server" without throwing errors

I don't understand very well what you mean. You want disable language server?

Start and stop existing server(s) at will when the running mode is changed.

If I understand correctly you want to start / stop language server with a Java API? If it that I have a PR redhat-developer/lsp4ij#318 for that (you can read documentation from the PR)

Configurations must be sent via workspace/didChangeConfiguration

We did that in Intellij Quarkus, see https://github.com/redhat-developer/intellij-quarkus/blob/f69407114100adb185a4fac8360e9ad3f8460706/src/main/java/com/redhat/devtools/intellij/qute/lsp/QuteLanguageClient.java#L104

• extends LanguageClientImpl (and dclar eit in extension point)
• implement createSettings to return the settings to send https://github.com/redhat-developer/intellij-quarkus/blob/f69407114100adb185a4fac8360e9ad3f8460706/src/main/java/com/redhat/devtools/intellij/qute/lsp/QuteLanguageClient.java#L91
• call triggerChangeConfiguration https://github.com/redhat-developer/intellij-quarkus/blob/f69407114100adb185a4fac8360e9ad3f8460706/src/main/java/com/redhat/devtools/intellij/qute/lsp/QuteLanguageClient.java#L104

[InSyncWithFoo]

You want disable language server?

That's correct. I would like to conditionally prevent it from being initialized.

If it that I have a PR redhat-developer/lsp4ij#318 for that (you can read documentation from the PR)

That PR seems to be what I'm looking for. Guess I'll have to wait until it is merged.

call triggerChangeConfiguration

Where am I supposed to call it? I need it to be sent just once right after initialization. QuteLanguageClient overrides profileChanged() from ProfileChangeAdapter, but what does that even do?

[angelozerr]

That's correct. I would like to conditionally prevent it from being initialized.

Ok, the PR redhat-developer/lsp4ij#318 manages that too. @fbricon we need to merge this PR ASAP because now we have 2 adaptors who need this support.

That PR seems to be what I'm looking for. Guess I'll have to wait until it is merged.

Great! Indeed we need to merge this PR and we plan to create a release as soon as this PR will be merged. See https://github.com/redhat-developer/lsp4ij/milestone/2

QuteLanguageClient overrides profileChanged() from ProfileChangeAdapter, but what does that even do?

The usecase with Qute is to track profile changed and send a didChangeConfiguration. In your case you want to call it when language server is started. Let me study how to do that.

[angelozerr]

Where am I supposed to call it?

See redhat-developer/lsp4ij#318 (comment)

[InSyncWithFoo]

This should be mergeable once #45 is merged.

[angelozerr]

@InSyncWithFoo once you will decide to adapt LSP4IJ could you please:

• create a PR in LSP4IJ to add your plugin in https://github.com/redhat-developer/lsp4ij?tab=readme-ov-file#who-is-using-lsp4ij
• add a review in https://plugins.jetbrains.com/plugin/23257-lsp4ij/edit/reviews to help us to promote LSP4IJ

Thanks!

[jonashaag]

I've been trying this branch for a couple of days and it seems to be working great!